From nobody Mon Aug 19 16:10:22 2024 X-Original-To: go@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Wncy71kVbz5TH9n for ; Mon, 19 Aug 2024 16:10:23 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Wncy70Vfjz4BrQ for ; Mon, 19 Aug 2024 16:10:23 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1724083823; a=rsa-sha256; cv=none; b=hxtvN+Z9vj58C1pfO0RbnTnH2E1gXOrQUcYxkU4cEKsnUd5M2fRjS1iRn4mgBQtxp4toTY sguuLHGkNbIiNWr6I8d/tWho+dVMSght5MzQpEi1mOOwMaxm50P/jxnzIHvyRazaWipBF8 J92oiyBkAfNXUqk2BLkXgNxb2v/8fdrdPtJPeHtWqcDy1Ymrtqn36b9PwZficCvXKjEATL 90/cYvCcUybKMvjPI7AqLcoer+Cc4VLad0i+9buZIWrYE3Bgk/ztKEeBoAm3mAEw8w8NpY 6wsTofFpKUrdEzeibnr6Mum6C8Rv00+5iqoR9s4cGa7zZ0Je+fkwwJSYK9y67A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724083823; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kukqEvOwY2N5Wlgc9Sv6TIP/6dXD4AoudW/S/ajvNfE=; b=ej8ckwLN835ptT6U1aWvHEAVPvT4YvLs7iYjPOHYspfS2cjOyj5vJFo6aYWtKPudh//aK0 XMwK0oBtFrw7FQHgtRxyeWTFu3Xg5WSndaMhQlcjcFO76/WZEsL8s4kZxE8RS/hSuLNXJz uzfe1qDAWvwxCOPvg2TvH2EdHu4Oc7y9nKQGFwvLP0FrIbirJzcxtDPjeOrp6vDq8IG+ac iqVC3YYLYRfK+jR3SHxCLkpsKBydwGbpiXFgOnA/OcugZ2H4e1gpwNHDtcKkkehEGBcOE5 FcOW0qreoAGnycj8VgtXJbm0lJsfQOnU5v+Ps0PaJSEcSnbVf8wNHq6S+nqy8w== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Wncy706p8zMxP for ; Mon, 19 Aug 2024 16:10:23 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 47JGAM0G042409 for ; Mon, 19 Aug 2024 16:10:22 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 47JGAMtJ042408 for go@FreeBSD.org; Mon, 19 Aug 2024 16:10:22 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: go@FreeBSD.org Subject: [Bug 280840] net-im/purple-gowhatsapp: maintainer upgrade from 1.15.0 to 1.16.0 Date: Mon, 19 Aug 2024 16:10:22 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: easy, patch-ready X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: freebsd-2024@virtual-estates.net X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: vvd@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: flagtypes.name Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Go language ports maintenance List-Archive: https://lists.freebsd.org/archives/freebsd-go List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: freebsd-go@freebsd.org Sender: owner-freebsd-go@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D280840 Mikhail T. changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #252922|maintainer-approval? |maintainer-approval- Flags| | --- Comment #9 from Mikhail T. --- Comment on attachment 252922 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D252922 v1: sort options, align lines, pet portclippy and portlint > but I renamed $o with $_db You renamed $o into ${_db} -- a multi-letter variable must be surrounded by braces in make -- which worsens the =C3=A6stethics considerably :( Also, ev= en though currently the only two options are, indeed, database-related, some day they= may be of other kind -- which is why I'd prefer the more generic "o", for "opti= on". The name of the multi-option is presented literally to the user -- and my original "DB-backends" is grammatically correct, whereas the new "DB_BACKEN= DS" is a perversion :( I know, you're trying to please portclippy et al, but I think, you're follo= wing it a little too blindly. The sorting of the options makes sense, but other changes are unappealing... Thank you! --=20 You are receiving this mail because: You are on the CC list for the bug.=