Re: Requiring SSE2 by default for i386

Hello,

As upstream defaults to use SSE2 on amd64/i386 I'm reproducing it on port.
I still don't get what this port has to do with rust SSE2 i386 requirement
as it doesn't use rust code, but I think we will get some performance
improvements.

If you need any change on port, please feel free to change it.

https://cgit.freebsd.org/ports/commit/?id=78b13cb9ecb8c0c0f59e09ba8d0264d023d6f688

Cheers,


Alan Somers <asomers@freebsd.org> escreveu (segunda, 11/11/2024 à(s) 20:50):

> Sounds good.
>
> On Mon, Nov 11, 2024 at 1:30 PM Nuno Teixeira <eduardo@freebsd.org> wrote:
> >
> > Ah, sure.
> >
> > I will add OPTIONS_DEFAULT=SSE2 and check if it will be problems for
> amd64 and aarch64.
> > If everything ok then use this option since upstream default is SSE2 on
> by default.
> >
> > Sorry as I misread past email.
> >
> > Alan Somers <asomers@freebsd.org> escreveu (segunda, 11/11/2024 à(s)
> 16:25):
> >>
> >> I don't know what that "QMAKE_ON" part means.  But when I do "make
> >> config", it shows the SSE2 option disabled by default.
> >>
> >> On Mon, Nov 11, 2024 at 5:20 AM Nuno Teixeira <eduardo@freebsd.org>
> wrote:
> >> >
> >> > (...)
> >> >
> >> > Just took a look at port Makefile and it's alleady set:
> >> >
> >> > OPTIONS_DEFINE= SSE2
> >> > SSE2_DESC=      Enable SSE2 optimization
> >> > SSE2_QMAKE_ON=  CONFIG+=sse2
> >> > SSE2_QMAKE_OFF= CONFIG+=no-sse2
> >> >
> >> > This port does not have rust code.
> >> >
> >> > Alan Somers <asomers@freebsd.org> escreveu (domingo, 10/11/2024 à(s)
> 15:51):
> >> >>
> >> >> On Sun, Nov 10, 2024 at 7:00 AM Nuno Teixeira <eduardo@freebsd.org>
> wrote:
> >> >> >
> >> >> > Hello,
> >> >> >
> >> >> >> graphics/fraqtive
> >> >> >
> >> >> >
> >> >> >
> https://github.com/mimecorg/fraqtive/blob/02914797f47d26c4098f4a3a945716b13998a8cc/INSTALL#L43
> >> >> > Upstream says SSE2 is enabled by default.
> >> >> >
> >> >> > What should we do here?
> >> >>
> >> >> Just set OPTIONS_DEFAULT_i386=SSE2 or OPTIONS_DEFAULT=SSE2 in the
> port Makefile.
> >> >
> >> >
> >> >
> >> > --
> >> > Nuno Teixeira
> >> > FreeBSD UNIX:  <eduardo@FreeBSD.org>   Web:  https://FreeBSD.org
> >
> >
> >
> > --
> > Nuno Teixeira
> > FreeBSD UNIX:  <eduardo@FreeBSD.org>   Web:  https://FreeBSD.org
>


-- 
Nuno Teixeira
FreeBSD UNIX:  <eduardo@FreeBSD.org>   Web:  https://FreeBSD.org