Re: Proposed Github Pull Request Policy

On Fri, Feb 3, 2023 at 9:42 AM Brooks Davis <brooks@freebsd.org> wrote:

> On Thu, Feb 02, 2023 at 07:12:29PM -0700, Warner Losh wrote:
> > Geetngs,
> >
> > I'd like to put some parameters around the pull requests on github. To
> that
> > end, I'd like us to consider the following policy:
>
> This seems like a good start.
>
> > Pull requests shouldn't expand in scope in response to feedback: If the
> > feedback suggests a new series of changes, please create a new pull
> > requests.
>
> I think I'd prefer: "Pull requests shouldn't expand in scope once
> created:...".
>
> Some direction on using rebase and forced push when addressing feedback is
> probably also in order.  If I'm taking a few minutes to look at a PR that
> caught my eye I don't want to wade through a bunch of fixups.
>

I've written this up as https://reviews.freebsd.org/D38382 which I'm open
to feedback on. Especially other areas of the docs that need to be fixed to
be consistent.

Warner