From nobody Sat Feb 04 18:12:34 2023 X-Original-To: freebsd-git@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4P8LGY5nNGz3nhLH for ; Sat, 4 Feb 2023 18:12:37 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [IPv6:2a00:1450:4864:20::535]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4P8LGX6Hw0z3Cgn for ; Sat, 4 Feb 2023 18:12:36 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20210112.gappssmtp.com header.s=20210112 header.b=T9XIrBZE; spf=none (mx1.freebsd.org: domain of wlosh@bsdimp.com has no SPF policy when checking 2a00:1450:4864:20::535) smtp.mailfrom=wlosh@bsdimp.com; dmarc=none Received: by mail-ed1-x535.google.com with SMTP id v10so7998456edi.8 for ; Sat, 04 Feb 2023 10:12:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=AUXBxQldnHVfmYyxrUC9M+C/KnAd14aroNUHAowO4yI=; b=T9XIrBZE09ZdwcS2hS2qLRFsMH/E/26o6Wq9yngmGuP+7pBs6q67q4HbZO2pua7Wp1 SDbGy8XItUWHbOvGK34VeFMfKDqDMmROnKNSAUrIUZt6Mi04iiFRjDKhBD+WWh2Z8snl IAvI7Npu9yn148UnYUblNYPbo76H21NLHQns9bJAgbKr6dSSWhsNSb5NMHWpI9bKjNJU y2TcXRP42E5O7Kmm6eZoXWHYNIiscjQ4uK0g744T3r5S4gY3kX/vYFpjC1vTRozc1q6p 6unjygrOA2N9QGE8ZjejvqtsgJ/xoKwbiGqvnLkNJgkuyCLPzDf+ahw4sJrxZ2/Yv7Vu JIng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=AUXBxQldnHVfmYyxrUC9M+C/KnAd14aroNUHAowO4yI=; b=P4VBqk/RTyXoi7CLhhn6a6X4pLD+7WGOKuwllPJkM911A9nCdCB+bUnSOSDUiU/RYp m4P4kS0wXxo28hrOixup2jOR1Hs+6oygas05D6vdrXOmEQCokdHka7asu7vnavAArWjk 8IU5YRoWRlGVsBrZRYOy3ov28HkZpBJyYlRLjoETYd4UnPJZnHBgkV+fbE0R++uxVonK I0+jf1YNS/8ZSSdj/G+l4W4jI4S6kHgbR9eDs6RQM2M2hAeo1FOeOO3Zy5SsSsbzp5Tx pKNsYAKkFktRl4L4RCeYB48dSEPLzmib1Cy+pL2eH0xZyqgffvaWpGGTAZDtI1hHwS1m uwsg== X-Gm-Message-State: AO0yUKUEQcZS+Rs5hokuSrDp0ak2pvA7v3DUJkAs9bJ70X4rGyeriz90 1QY9ygxlL6ioYWqVy8/rtR00VxiAKa5rxP2bVySZM0KYmMzv/enw X-Google-Smtp-Source: AK7set973UYBtytWqZnhOOVl9DjjeZyY9Q6VMDsGIIMmesKzqmdRyaJ275aSJ2gGkByqC8wJKiaxZnBhaSuotzfPX3w= X-Received: by 2002:a05:6402:2489:b0:4a0:f071:3656 with SMTP id q9-20020a056402248900b004a0f0713656mr4550852eda.81.1675534355219; Sat, 04 Feb 2023 10:12:35 -0800 (PST) List-Id: Discussion of git use in the FreeBSD project List-Archive: https://lists.freebsd.org/archives/freebsd-git List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-git@freebsd.org MIME-Version: 1.0 References: In-Reply-To: From: Warner Losh Date: Sat, 4 Feb 2023 11:12:34 -0700 Message-ID: Subject: Re: Proposed Github Pull Request Policy To: Brooks Davis Cc: freebsd-git Content-Type: multipart/alternative; boundary="0000000000000d60ef05f3e3bee9" X-Spamd-Result: default: False [-3.00 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-0.998]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20210112.gappssmtp.com:s=20210112]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; ARC_NA(0.00)[]; MLMMJ_DEST(0.00)[freebsd-git@freebsd.org]; R_SPF_NA(0.00)[no SPF record]; RCVD_TLS_LAST(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; MIME_TRACE(0.00)[0:+,1:+,2:~]; RCVD_IN_DNSWL_NONE(0.00)[2a00:1450:4864:20::535:from]; DKIM_TRACE(0.00)[bsdimp-com.20210112.gappssmtp.com:+]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; PREVIOUSLY_DELIVERED(0.00)[freebsd-git@freebsd.org]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; DMARC_NA(0.00)[bsdimp.com]; TO_DN_ALL(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com] X-Rspamd-Queue-Id: 4P8LGX6Hw0z3Cgn X-Spamd-Bar: -- X-ThisMailContainsUnwantedMimeParts: N --0000000000000d60ef05f3e3bee9 Content-Type: text/plain; charset="UTF-8" On Fri, Feb 3, 2023 at 9:42 AM Brooks Davis wrote: > On Thu, Feb 02, 2023 at 07:12:29PM -0700, Warner Losh wrote: > > Geetngs, > > > > I'd like to put some parameters around the pull requests on github. To > that > > end, I'd like us to consider the following policy: > > This seems like a good start. > > > Pull requests shouldn't expand in scope in response to feedback: If the > > feedback suggests a new series of changes, please create a new pull > > requests. > > I think I'd prefer: "Pull requests shouldn't expand in scope once > created:...". > > Some direction on using rebase and forced push when addressing feedback is > probably also in order. If I'm taking a few minutes to look at a PR that > caught my eye I don't want to wade through a bunch of fixups. > I've written this up as https://reviews.freebsd.org/D38382 which I'm open to feedback on. Especially other areas of the docs that need to be fixed to be consistent. Warner --0000000000000d60ef05f3e3bee9 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Fri, Feb 3, 2023 at 9:42 AM Brooks= Davis <brooks@freebsd.org>= wrote:
On Thu, = Feb 02, 2023 at 07:12:29PM -0700, Warner Losh wrote:
> Geetngs,
>
> I'd like to put some parameters around the pull requests on github= . To that
> end, I'd like us to consider the following policy:

This seems like a good start.

> Pull requests shouldn't expand in scope in response to feedback: I= f the
> feedback suggests a new series of changes, please create a new pull > requests.

I think I'd prefer: "Pull requests shouldn't expand in scope o= nce
created:...".

Some direction on using rebase and forced push when addressing feedback is<= br> probably also in order.=C2=A0 If I'm taking a few minutes to look at a = PR that
caught my eye I don't want to wade through a bunch of fixups.

I've written this up as https://reviews.freebsd.org/D38382 which I&#= 39;m open to feedback on. Especially other areas of the docs that need to b= e fixed to be consistent.

Warner
<= /div> --0000000000000d60ef05f3e3bee9--