Re: src tools/tools/git/hooks/prepare-commit-msg ?

From: Warner Losh <imp_at_bsdimp.com>
Date: Thu, 20 May 2021 23:20:09 UTC
Hi Bjoern,

Sorry to take a little to get back to you... I was on travel and got
behind...

On Wed, May 19, 2021 at 6:38 AM Bjoern A. Zeeb <
bzeeb-lists@lists.zabbadoz.net> wrote:

> Hi,
>
> before committer's guide (CG) git docs on Warner's github the tags were
> documented as "Foo-bar:" ineast of the old "Foo bar":  ; see:
>
> https://github.com/bsdimp/freebsd-git-docs/blob/096afef4a8b9d8964f9edaf3d15e484b1ead83d3/meta.md
> (with the later fix for Phabricator).
>
> It seems tools/tools/git/hooks/prepare-commit-msg in the source tree
> was never updated to that?
>
> I can find a reference to the hook in the ports (not in the src) section
> "5.2.6.1. Commit message formats" of the CG and the referenced file
> for ports also was never changed it seems.
>
> Did we drop the idea of adding the "-" into the "tags"?
>
>
> I am asking because I kept using them from back then and noticed that
> I am missing a lot of MFC reminders (though I thought that was
> adjusted to cope with the '-' as well).  So I am trying to sort out
> the official format before opening the next can.
>

I think that you should omit them, and if we still document them like that
we should change it. The git group tried to promulgate the change, but
it has had poor uptake.

Either that, or we need to make the mfc stuff work again... Though given the
numbers of people that have used the '-' versions appears to be low, I think
we'll need to relaunch in the future instead.

Warner


> /bz
>
> --
> Bjoern A. Zeeb                                                     r15:7
>
>