From nobody Thu May 20 23:20:09 2021 X-Original-To: git@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4620C8B4977 for ; Thu, 20 May 2021 23:20:22 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qk1-x735.google.com (mail-qk1-x735.google.com [IPv6:2607:f8b0:4864:20::735]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FmQh53NyXz4R9s for ; Thu, 20 May 2021 23:20:21 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qk1-x735.google.com with SMTP id 76so17980474qkn.13 for ; Thu, 20 May 2021 16:20:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/2bWzFAo+jcLfA5g80N/DFQE0QWjUs81jcjWt7H7N/g=; b=2NwcwsQEO/pkpgaiCJpBNV0Coqj7ZlHIDiYMZtDu6qqOCODit6a7QHLSFX6yMcRIe8 /SwhOuZJYS/FXKRN0Vhh6DpNJoVZiP/I5n4jG1kdQVWaMq5DnDvwylu+nzF6FSRyLeKn MzRUHvLBA13AgSwU0X6tq5Ti9IpsNUSXe/5wBKuTPfrquVjLz7KqKSabqpLL+MFHaBpM gSoGxhrDpoL9wfTBmKQpcduiHlOPMjFZ611qPjTUaLQwQiBvldVHXPvm5GwajJmb2nZi 8utnr0uzbB2le4jjSnetgRBEUr+hG3pxIbwdozpvKzWtozr63VjtiCaaLpuLR/TS5um6 VE5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/2bWzFAo+jcLfA5g80N/DFQE0QWjUs81jcjWt7H7N/g=; b=FYeCMBriBOCd6i/kboMyItW8IfGVzpe9H5bsJtLkqhbN+QGJeo/0x3fNyV6hG+6v5R zk5dcntkvYZ5OaSSr0sQGdkgZrpROrhdXtN7eA3R/07zIiDfI2DUwCT7vvlNrOXMDqmq OG9GftSPTHKp8FGLy8ZNH+tUhQY8Xhlm5aLDucKxh3PNcviPrRZt3Mw3p5GmJXKY+wMH gozAjxt/9utp0I3zfLzbZ7eqfISvqwEJ5hFHrGsCo5iC8sMZz8C/WDwyMuTlg6wtChCk bi8Gk8nAbwoBQDb5lpuCMGEQ58kJEk/PgI6wCCfXJ2AcHVVgUtvag56O26zz/7z41hG9 mDPw== X-Gm-Message-State: AOAM533P4F++e1X74jYo5rb159JnqmDEfbQETqC71tuJnQKLJ0n75J+3 Lz7/ubrjQ62mHoX/XmPa3ufU6ZlQK4RnjiBh51M4Y2YZJCw= X-Google-Smtp-Source: ABdhPJxivbdp2w0lZ6Glm1xex3YJV6X/GPVENoAMfk7g51DoIjq7QIcz2L1lMv8x/rTNE9bstvlZUTkSNIp1VAvgB4k= X-Received: by 2002:a37:7685:: with SMTP id r127mr8137737qkc.359.1621552820641; Thu, 20 May 2021 16:20:20 -0700 (PDT) List-Id: Discussion of git use in the FreeBSD project List-Archive: https://lists.freebsd.org/archives/freebsd-git List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-git@freebsd.org MIME-Version: 1.0 References: In-Reply-To: From: Warner Losh Date: Thu, 20 May 2021 17:20:09 -0600 Message-ID: Subject: Re: src tools/tools/git/hooks/prepare-commit-msg ? To: "Bjoern A. Zeeb" Cc: git@freebsd.org Content-Type: multipart/alternative; boundary="000000000000dbf6e405c2cb2f19" X-Rspamd-Queue-Id: 4FmQh53NyXz4R9s X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20150623.gappssmtp.com header.s=20150623 header.b=2NwcwsQE; dmarc=none; spf=none (mx1.freebsd.org: domain of wlosh@bsdimp.com has no SPF policy when checking 2607:f8b0:4864:20::735) smtp.mailfrom=wlosh@bsdimp.com X-Spamd-Result: default: False [-1.95 / 15.00]; RCVD_TLS_ALL(0.00)[]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20150623.gappssmtp.com:s=20150623]; NEURAL_HAM_MEDIUM(-0.95)[-0.952]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[git@freebsd.org]; DMARC_NA(0.00)[bsdimp.com]; SPAMHAUS_ZRD(0.00)[2607:f8b0:4864:20::735:from:127.0.2.255]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RBL_DBL_DONT_QUERY_IPS(0.00)[2607:f8b0:4864:20::735:from]; DKIM_TRACE(0.00)[bsdimp-com.20150623.gappssmtp.com:+]; RCPT_COUNT_TWO(0.00)[2]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::735:from]; NEURAL_HAM_SHORT(-1.00)[-1.000]; R_SPF_NA(0.00)[no SPF record]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; MIME_TRACE(0.00)[0:+,1:+,2:~]; SUBJECT_ENDS_QUESTION(1.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; MAILMAN_DEST(0.00)[git]; RCVD_COUNT_TWO(0.00)[2] --000000000000dbf6e405c2cb2f19 Content-Type: text/plain; charset="UTF-8" Hi Bjoern, Sorry to take a little to get back to you... I was on travel and got behind... On Wed, May 19, 2021 at 6:38 AM Bjoern A. Zeeb < bzeeb-lists@lists.zabbadoz.net> wrote: > Hi, > > before committer's guide (CG) git docs on Warner's github the tags were > documented as "Foo-bar:" ineast of the old "Foo bar": ; see: > > https://github.com/bsdimp/freebsd-git-docs/blob/096afef4a8b9d8964f9edaf3d15e484b1ead83d3/meta.md > (with the later fix for Phabricator). > > It seems tools/tools/git/hooks/prepare-commit-msg in the source tree > was never updated to that? > > I can find a reference to the hook in the ports (not in the src) section > "5.2.6.1. Commit message formats" of the CG and the referenced file > for ports also was never changed it seems. > > Did we drop the idea of adding the "-" into the "tags"? > > > I am asking because I kept using them from back then and noticed that > I am missing a lot of MFC reminders (though I thought that was > adjusted to cope with the '-' as well). So I am trying to sort out > the official format before opening the next can. > I think that you should omit them, and if we still document them like that we should change it. The git group tried to promulgate the change, but it has had poor uptake. Either that, or we need to make the mfc stuff work again... Though given the numbers of people that have used the '-' versions appears to be low, I think we'll need to relaunch in the future instead. Warner > /bz > > -- > Bjoern A. Zeeb r15:7 > > --000000000000dbf6e405c2cb2f19 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Bjoern,

Sorry to ta= ke a little to get back to you... I was on travel and got behind...

On= Wed, May 19, 2021 at 6:38 AM Bjoern A. Zeeb <bzeeb-lists@lists.zabbadoz.net> wrote:
Hi,

before committer's guide (CG) git docs on Warner's github the tags = were
documented as "Foo-bar:" ineast of the old "Foo bar":= =C2=A0 ; see:
http= s://github.com/bsdimp/freebsd-git-docs/blob/096afef4a8b9d8964f9edaf3d15e484= b1ead83d3/meta.md
(with the later fix for Phabricator).

It seems tools/tools/git/hooks/prepare-commit-msg in the source tree
was never updated to that?

I can find a reference to the hook in the ports (not in the src) section "5.2.6.1. Commit message formats" of the CG and the referenced fi= le
for ports also was never changed it seems.

Did we drop the idea of adding the "-" into the "tags"?=


I am asking because I kept using them from back then and noticed that
I am missing a lot of MFC reminders (though I thought that was
adjusted to cope with the '-' as well).=C2=A0 So I am trying to sor= t out
the official format before opening the next can.

<= /div>
I think that you should omit them, and if we still document them = like that
we should change it. The git group tried to promulgate = the change, but
it has had poor uptake.

= Either that, or we need to make the mfc stuff work again... Though given th= e
numbers of people that have used the '-' versions appea= rs to be low, I think
we'll need to relaunch in the future in= stead.

Warner
=C2=A0
/bz

--
Bjoern A. Zeeb=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0r15:7

--000000000000dbf6e405c2cb2f19--