Re: Is there any way to nudge security/libfido2? It blocks chunks of KDE

On Sun, Jan 5, 2025, 3:43 AM Ronald Klop <ronald-lists@klop.ws> wrote:

>
> *Van:* Dennis Clarke <dclarke@blastwave.org>
> *Datum:* zondag, 5 januari 2025 06:45l
> *Aan:* Current FreeBSD <freebsd-current@freebsd.org>
> *Onderwerp:* Is there any way to nudge security/libfido2? It blocks
> chunks of KDE
>
>
>      It seems to have been a while since I was able to run a poudriere
> bulk build and get KDE available. At least on 15-CURRENT. There is a
> little brick in the path called security/libfido2 :
>
>      https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=283697
>
> commit 74ecdf86d8d2a94a4bfcf094a2e21b4747e4907f resulted in the
> appropriate declarations for the correct versions of _POSIX_C_SOURCE
> via __POSIX_VISIBLE and then we get
>
> error: call to undeclared function 'ppoll'; ISO C99 and later do not
> support implicit function declarations
> [-Werror,-Wimplicit-function-declaration]
>
>
> Sort of annoying as even 14.2-RELEASE on amd64 and ports 2024Q4 fails :
>
> [142amd64-2024Q4] [2025-01-04_10h11m35s] [committing] Queued: 5  Built: 4
>  Failed: 1  Skipped: 0  Ignored: 0  Fetched: 0  Tobuild: 0   Time: 00:04:44
>
> The 15.0-CURRENT is much much worse :
>
> [150amd64-latest] [2025-01-04_08h12m11s] [committing] Queued: 365 Built:
> 323 Failed: 2   Skipped: 40  Ignored: 0   Fetched: 0   Tobuild: 0 Time:
> 01:52:01
>
>
> In any case ... is there a way to nudge that ?
>
> --
> --
> Dennis Clarke
> RISC-V/SPARC/PPC/ARM/CISC
> UNIX and Linux spoken
>
> ------------------------------
>
>
>
> Hi,
>
> The issue is assigned and the port has an active maintainer so that looks
> good.
> I see you replied on the issue with a patch for a solution, but the patch
> is hidden in quite a large comment (I needed to read it twice before I
> spotted it). It can help to put the patch in an attachment of the issue as
> type 'patch'.
> You can send an email to ports@freebsd.org to get the attention of the
> ports managers.
> It can also help to open an upstream issue on the github repo of libfido.
> If the patch is accepted there it is a good argument to get the patch into
> FreeBSD.
>
> NB: I understand your feeling of urgency in this. In the meantime this is
> also a period of holidays/weekend, etc.
>

Yes. The port can't define __BSD_VISIBLE directly. That's bogus. Also both
_POSIX_C_SORCE and _BSD_SOURCE is bogus. The solution is super simple: just
don't define POSIX_C_SOURCE since you are obviously trying to use something
that's not defined in the version of POSIX you are requesting the strict
namespace for.

Warner

Hope this helps.
>
> Regards,
> Ronald.
>
>