From nobody Sun Jan 05 17:42:20 2025 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YR4QL4zSpz5k1F2 for ; Sun, 05 Jan 2025 17:42:34 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-pj1-x1030.google.com (mail-pj1-x1030.google.com [IPv6:2607:f8b0:4864:20::1030]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YR4QK3Gzmz4F2m for ; Sun, 5 Jan 2025 17:42:33 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-pj1-x1030.google.com with SMTP id 98e67ed59e1d1-2ef28f07dbaso15314574a91.2 for ; Sun, 05 Jan 2025 09:42:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20230601.gappssmtp.com; s=20230601; t=1736098952; x=1736703752; darn=freebsd.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=i93KlWd0iPoxkPKLpSWHvezbHAVFoy7zhkZwR6f+QWI=; b=DRbTn0cIhILPDY3XpPt7AbA2bKVq0J+WgVUJbAWm2irv+G1bmslE92fjfTUY2kqg74 nS3e486PhF45jSnJpaxPgjSLViiugU1yQ3cYFGdf0rL+19GSOaPnmOQKlWP/NjzaO9G0 t5g4cw6OB4XARkdDP+1sc6bHcfhMukuFRcBkzr3/WM3qDCzIy9rZ+NONrQBbqg2PhlX7 yTKe/4Et+ZGkF2cq/lemB6jDjdreiXRUp3aLprqsyABQQ8iPGbwVLko8yRklUSZsFXOd kMHMIhwH7Dj87KHmOQaj1ikTjPxRyNVbYXwM5tEEJNKCeEfahGLIAzIS5S1WQd2nSQJv qsyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736098952; x=1736703752; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=i93KlWd0iPoxkPKLpSWHvezbHAVFoy7zhkZwR6f+QWI=; b=GCoTmWpeQ43AQ6AgOyXIlJpO4FuUHthtNudmLytbhJP9Rg0YdBFDP0aNMo2lO3t5Ce J1e92sFzf6khXIceaMqf+nf9J6YmM8A81lfyRzo4Jg/AoA1liBrWklf8yPw08xBsveHW lJRQ/oxOHJHQ0kCSYQwk5ngO0yvdEr49VpPtIWo/N8i9Vr056oA2mNp4KXl2V0GUBM1+ 0XTpMMQ7Kq8yU0UkrSOZ5nl3mUDXV3c4dnDTq8VpLmdHzhY+zpstFyYM3hw+dImdU7Se EVe+aDTD2xD95GlitkemQlkQ3EaVU9DYtIJjycOZtyZS+vRmA6S50pQuuSZigjSPbrSS mdBA== X-Forwarded-Encrypted: i=1; AJvYcCVB2ehAx9lu+kJeKFevggPRXjIyLYBJoY4/lteONF75QtXzweUAH7gA5Y/XCyHWDBJDcF2XK/bThxX0eEW0Ktg=@freebsd.org X-Gm-Message-State: AOJu0YyyXRh7xVtVOZB6QrA8Bg1G026dy7X1BU31i8whnrZaZ7Ft/9VH U4551D7+yerBLxz7eLuEJfvI1I4a/uNz+bFq8HQU+4zm3vOEzPn+eQmjDvg6o2mxONt04VgMVUF dsVJHNdit19BgVXUO9LnJbhkojcf1DuKLpQO2eDHfPr83dH6OIZo= X-Gm-Gg: ASbGncs7e+DHjYxs+rmGXtljYaakVqZ9BihtMZ99Ws/LbWJ2DEX4U6AFv96CRmwBBWd Ddgzl4V1XpPE840OY43dTPDy3ua8p6eyOe/J3HA== X-Google-Smtp-Source: AGHT+IGMvfjxss3ygri4BpHs5fqEAyW2KKWCAg0QsYHBFo5rijstS+IU3awTkaFhl++F2wtHmNQBSYbZJTFIIl8+CPs= X-Received: by 2002:a17:90b:2f45:b0:2ea:aa56:499 with SMTP id 98e67ed59e1d1-2f452dee49fmr82507758a91.1.1736098952135; Sun, 05 Jan 2025 09:42:32 -0800 (PST) List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@FreeBSD.org MIME-Version: 1.0 References: <36c212cc-0da9-43b7-b760-d29d71bc35e5@blastwave.org> <1645708192.12009.1736073795989@localhost> In-Reply-To: <1645708192.12009.1736073795989@localhost> From: Warner Losh Date: Sun, 5 Jan 2025 10:42:20 -0700 Message-ID: Subject: Re: Is there any way to nudge security/libfido2? It blocks chunks of KDE To: Ronald Klop Cc: Dennis Clarke , Current FreeBSD Content-Type: multipart/alternative; boundary="00000000000056665e062af90934" X-Rspamd-Queue-Id: 4YR4QK3Gzmz4F2m X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] --00000000000056665e062af90934 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sun, Jan 5, 2025, 3:43=E2=80=AFAM Ronald Klop wro= te: > > *Van:* Dennis Clarke > *Datum:* zondag, 5 januari 2025 06:45l > *Aan:* Current FreeBSD > *Onderwerp:* Is there any way to nudge security/libfido2? It blocks > chunks of KDE > > > It seems to have been a while since I was able to run a poudriere > bulk build and get KDE available. At least on 15-CURRENT. There is a > little brick in the path called security/libfido2 : > > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D283697 > > commit 74ecdf86d8d2a94a4bfcf094a2e21b4747e4907f resulted in the > appropriate declarations for the correct versions of _POSIX_C_SOURCE > via __POSIX_VISIBLE and then we get > > error: call to undeclared function 'ppoll'; ISO C99 and later do not > support implicit function declarations > [-Werror,-Wimplicit-function-declaration] > > > Sort of annoying as even 14.2-RELEASE on amd64 and ports 2024Q4 fails : > > [142amd64-2024Q4] [2025-01-04_10h11m35s] [committing] Queued: 5 Built: 4 > Failed: 1 Skipped: 0 Ignored: 0 Fetched: 0 Tobuild: 0 Time: 00:04:= 44 > > The 15.0-CURRENT is much much worse : > > [150amd64-latest] [2025-01-04_08h12m11s] [committing] Queued: 365 Built: > 323 Failed: 2 Skipped: 40 Ignored: 0 Fetched: 0 Tobuild: 0 Time: > 01:52:01 > > > In any case ... is there a way to nudge that ? > > -- > -- > Dennis Clarke > RISC-V/SPARC/PPC/ARM/CISC > UNIX and Linux spoken > > ------------------------------ > > > > Hi, > > The issue is assigned and the port has an active maintainer so that looks > good. > I see you replied on the issue with a patch for a solution, but the patch > is hidden in quite a large comment (I needed to read it twice before I > spotted it). It can help to put the patch in an attachment of the issue a= s > type 'patch'. > You can send an email to ports@freebsd.org to get the attention of the > ports managers. > It can also help to open an upstream issue on the github repo of libfido. > If the patch is accepted there it is a good argument to get the patch int= o > FreeBSD. > > NB: I understand your feeling of urgency in this. In the meantime this is > also a period of holidays/weekend, etc. > Yes. The port can't define __BSD_VISIBLE directly. That's bogus. Also both _POSIX_C_SORCE and _BSD_SOURCE is bogus. The solution is super simple: just don't define POSIX_C_SOURCE since you are obviously trying to use something that's not defined in the version of POSIX you are requesting the strict namespace for. Warner Hope this helps. > > Regards, > Ronald. > > --00000000000056665e062af90934 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Sun, Jan 5, 2025, 3:43=E2=80=AFAM = Ronald Klop <r= onald-lists@klop.ws> wrote:
=

Van: Dennis Clarke <dclarke@blastwave.org>=
Datum: zondag, 5 januari 2025 06:45l
Aan: Current FreeBSD <freebsd-current@freebsd.= org>
Onderwerp: Is there any way to nudge security/libfido2? It= blocks chunks of KDE


=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0It seems to have been a while since I was abl= e to run a poudriere bulk build and get KDE available. At least on 15-CURRE= NT. There is a
little brick in the path called security/libfido2 :

=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0https://bugs= .freebsd.org/bugzilla/show_bug.cgi?id=3D283697

commit 74ecdf86d8d2a94a4bfcf094a2e21b4747e4907f resulted in the
appropriate declarations for the correct versions of _POSIX_C_SOURCE
via __POSIX_VISIBLE and then we get

error: call to undeclared function 'ppoll'; ISO C99 and later do no= t support implicit function declarations [-Werror,-Wimplicit-function-decla= ration]


Sort of annoying as even 14.2-RELEASE on amd64 and ports 2024Q4 fails :

[142amd64-2024Q4] [2025-01-04_10h11m35s] [committing] Queued: 5 =C2=A0Built= : 4 =C2=A0Failed: 1 =C2=A0Skipped: 0 =C2=A0Ignored: 0 =C2=A0Fetched: 0 =C2= =A0Tobuild: 0 =C2=A0=C2=A0Time: 00:04:44

The 15.0-CURRENT is much much worse :

[150amd64-latest] [2025-01-04_08h12m11s] [committing] Queued: 365 Built: 32= 3 Failed: 2 =C2=A0=C2=A0Skipped: 40 =C2=A0Ignored: 0 =C2=A0=C2=A0Fetched: 0= =C2=A0=C2=A0Tobuild: 0 Time: 01:52:01


In any case ... is there a way to nudge that ?

--=C2=A0
--
Dennis Clarke
RISC-V/SPARC/PPC/ARM/CISC
UNIX and Linux spoken
=C2=A0



Hi,

The issue is assigned and the port has an active maintainer so that looks g= ood.
I see you replied on the issue with a patch for a solution, but the patch i= s hidden in quite a large comment (I needed to read it twice before I spott= ed it). It can help to put the patch in an attachment of the issue as type = 'patch'.
You can send an email to ports@freebsd.org to get the attention of the p= orts managers.
It can also help to open an upstream issue on the github repo of libfido. I= f the patch is accepted there it is a good argument to get the patch into F= reeBSD.

NB: I understand your feeling of urgency in this. In the meantime this is a= lso a period of holidays/weekend, etc.

Yes. The port can't define = __BSD_VISIBLE directly. That's bogus. Also both _POSIX_C_SORCE and _BSD= _SOURCE is bogus. The solution is super simple: just don't define POSIX= _C_SOURCE since you are obviously trying to use something that's not de= fined in the version of POSIX you are requesting the strict namespace for.<= /div>

Warner

Hope this helps.

Regards,
Ronald.
=C2=A0
--00000000000056665e062af90934--