Re: loader.efi: "Malformed line (27)" error apparently due to recent splash config entry

Hey Rebecca

I've uploaded this differential

https://reviews.freebsd.org/D47201

which should fix it. We should allow " in # comments, but at the moment we
don't. We should also fix the
parser to allow it. Since stabilization week is coming up, I'd like to rush
this in, if it works.

Warner

On Sat, Oct 19, 2024 at 9:45 AM Rebecca Cran <rebecca@bsdio.com> wrote:

> I just updated one of my systems (an AArch64 ADLINK Ampere Altra Dev
> Kit) to the latest -CURRENT and copied the latest /boot/loader.efi into
> /boot/efi/efi/freebsd/loader.efi and /boot/efi/efi/boot/bootaa64.efi and
> noticed a new message during boot, apparently introduced in this commit?
>
>
> commit 7df3e400ea68722b6263cd71937e43a98585eeda
> Author: Emmanuel Vadot <manu@FreeBSD.org>
> Date:   Mon Oct 14 11:25:57 2024 +0200
>
>      loader: default: Add a default splash screen
>
>      Setting boot_mute="YES" currently use the in-kernel black and white
> logo.
>      Instead default to the color png one.
>
>      Sponsored by:   Beckhoff Automation GmbH & Co. KGSetting currdev to
> zfs:zroot/ROOT/default:
>
>
> The messages are:
>
> Loading /boot/defaults/loader.conf
> Loading /boot/defaults/loader.conf
> Malformed line (27):
>          'splash="/boot/images/freebsd-logo-rev.png"  # Set
> boot_mute="YES" to load it'
> Failed to parse config: '/boot/defaults/loader.conf'
> Loading /boot/device.hints
>
> --
> Rebecca Cran
>
>
>