From nobody Sat Oct 19 18:19:52 2024 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XW8xf3tZ6z5YsWy for ; Sat, 19 Oct 2024 18:20:06 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-pg1-x52c.google.com (mail-pg1-x52c.google.com [IPv6:2607:f8b0:4864:20::52c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XW8xf23rXz3xs4 for ; Sat, 19 Oct 2024 18:20:06 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-pg1-x52c.google.com with SMTP id 41be03b00d2f7-7ea79711fd4so2239596a12.0 for ; Sat, 19 Oct 2024 11:20:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20230601.gappssmtp.com; s=20230601; t=1729362004; x=1729966804; darn=freebsd.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=jMb0DWxIwlInsy0TGwhksrlMCJn9AbB8f/Og4o8W0Wg=; b=wNHS6isvym3p72JlkQ/vGL948F3zlCd75FHVNqljL/p1oepMpAfYldNw6Cf0utcIFf 1TZJ0FB3QfAy/mUQydVJdUZq/n6ISASGsLbH/H1SzCtKwoCpUy5q9CpqBARd2q86dbAM afePxQZP0A9EEur3useqYLVJFfZobT9HEo98+5hDL6hYqkEb4M/SMTloWfmahykqWVNF 2bz0IvnISZ6Jr5UYcsAjojNVvvbdVE5ys6wtzB0JIL0450P+1d/2jEu7fYl+0OvbLe3f To8byo7Kz1epTTu59dAY7MPP7KXCbajxxg1DxGS5hCZSFcOBpJhid4yjUX709tQadz+t ChSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729362004; x=1729966804; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jMb0DWxIwlInsy0TGwhksrlMCJn9AbB8f/Og4o8W0Wg=; b=wdTOaQDOzZiFEBIzbAcLktyEqoGZmNQkU/4QZeBl8UifqCtB/9feiRHi7fsBgEd1Ry U/KSJPzdEXjDqXVU230HGSBAUErvtqA29vD9LHi54He7cp5QgbHiXtN+nUZsch7ipq5e +6canVlCSyU1dcqoST2Wi9tbbRQtBteeFmErTIsvaq3J4XFoZKCQuXfeaKTOO3tCXQD/ pR4BHrr2e+pRIP3Hsv8j/lDz5rFLwB7v+4HjukyW1cwh70/VgAjaTsuWPzZcFIApqBwt zwjMAus+bNOwhZNf0mvcGuCba0y8u7UIgJhcnpWEeK3LHa1myjIgrXGaKzHs4T/rFtMf IM4w== X-Gm-Message-State: AOJu0YxXYmER9V4hlXb0C++usF13g7PklYb7FSZr2JfoLLxV+uZc+1X8 nM2hFUz6hGPmth+Q3HS5ngyAcP0oN5dZalQPxqEizDEdt5bwp8lmSKdJBLi9d9n+7OOlxYY1MYQ SlNanJxvA3ywuXECghuvYEys+i/cLk7BMZkpStQ== X-Google-Smtp-Source: AGHT+IFDG2WJGeNgvQkQWyaQh+lZY4WGdqnyYd47QGzIFVhXYTJOPcVW33tOhXDnHUfWgc9S8/YoOgyZcb9gktb9uZM= X-Received: by 2002:a05:6a21:1690:b0:1d9:af2:6143 with SMTP id adf61e73a8af0-1d92c4e13c3mr9813061637.16.1729362004289; Sat, 19 Oct 2024 11:20:04 -0700 (PDT) List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@FreeBSD.org MIME-Version: 1.0 References: <52524135-d232-460a-9961-1fbc4463f6ba@bsdio.com> In-Reply-To: <52524135-d232-460a-9961-1fbc4463f6ba@bsdio.com> From: Warner Losh Date: Sat, 19 Oct 2024 12:19:52 -0600 Message-ID: Subject: Re: loader.efi: "Malformed line (27)" error apparently due to recent splash config entry To: Rebecca Cran Cc: Current FreeBSD , Emmanuel Vadot Content-Type: multipart/alternative; boundary="000000000000f4499c0624d8772b" X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Rspamd-Queue-Id: 4XW8xf23rXz3xs4 X-Spamd-Bar: ---- --000000000000f4499c0624d8772b Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hey Rebecca I've uploaded this differential https://reviews.freebsd.org/D47201 which should fix it. We should allow " in # comments, but at the moment we don't. We should also fix the parser to allow it. Since stabilization week is coming up, I'd like to rush this in, if it works. Warner On Sat, Oct 19, 2024 at 9:45=E2=80=AFAM Rebecca Cran wr= ote: > I just updated one of my systems (an AArch64 ADLINK Ampere Altra Dev > Kit) to the latest -CURRENT and copied the latest /boot/loader.efi into > /boot/efi/efi/freebsd/loader.efi and /boot/efi/efi/boot/bootaa64.efi and > noticed a new message during boot, apparently introduced in this commit? > > > commit 7df3e400ea68722b6263cd71937e43a98585eeda > Author: Emmanuel Vadot > Date: Mon Oct 14 11:25:57 2024 +0200 > > loader: default: Add a default splash screen > > Setting boot_mute=3D"YES" currently use the in-kernel black and whit= e > logo. > Instead default to the color png one. > > Sponsored by: Beckhoff Automation GmbH & Co. KGSetting currdev to > zfs:zroot/ROOT/default: > > > The messages are: > > Loading /boot/defaults/loader.conf > Loading /boot/defaults/loader.conf > Malformed line (27): > 'splash=3D"/boot/images/freebsd-logo-rev.png" # Set > boot_mute=3D"YES" to load it' > Failed to parse config: '/boot/defaults/loader.conf' > Loading /boot/device.hints > > -- > Rebecca Cran > > > --000000000000f4499c0624d8772b Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hey Rebecca

I've uploade= d this differential

https://reviews.freebsd.org/D47201

w= hich should fix it. We should allow " in # comments, but at the moment= we don't. We should also fix the
parser to allow it. Since s= tabilization week is coming up, I'd like to rush this in, if it works.<= /div>

Warner

<= div dir=3D"ltr" class=3D"gmail_attr">On Sat, Oct 19, 2024 at 9:45=E2=80=AFA= M Rebecca Cran <rebecca@bsdio.com> wrote:
I = just updated one of my systems (an AArch64 ADLINK Ampere Altra Dev
Kit) to the latest -CURRENT and copied the latest /boot/loader.efi into /boot/efi/efi/freebsd/loader.efi and /boot/efi/efi/boot/bootaa64.efi and noticed a new message during boot, apparently introduced in this commit?

commit 7df3e400ea68722b6263cd71937e43a98585eeda
Author: Emmanuel Vadot <manu@FreeBSD.org>
Date:=C2=A0=C2=A0 Mon Oct 14 11:25:57 2024 +0200

=C2=A0=C2=A0=C2=A0=C2=A0 loader: default: Add a default splash screen

=C2=A0=C2=A0=C2=A0=C2=A0 Setting boot_mute=3D"YES" currently use = the in-kernel black and white
logo.
=C2=A0=C2=A0=C2=A0=C2=A0 Instead default to the color png one.

=C2=A0=C2=A0=C2=A0=C2=A0 Sponsored by:=C2=A0=C2=A0 Beckhoff Automation GmbH= & Co. KGSetting currdev to
zfs:zroot/ROOT/default:


The messages are:

Loading /boot/defaults/loader.conf
Loading /boot/defaults/loader.conf
Malformed line (27):
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 'splash=3D"/boot/= images/freebsd-logo-rev.png"=C2=A0 # Set
boot_mute=3D"YES" to load it'
Failed to parse config: '/boot/defaults/loader.conf'
Loading /boot/device.hints

--
Rebecca Cran


--000000000000f4499c0624d8772b--