Re: Removing fdisk and bsdlabel (legacy partition tools)

On Wed, 24 Jan 2024 at 12:30, Warner Losh <imp@bsdimp.com> wrote:
>
> Those are the only users in the tree, but not for long :)

I have some reviews open to remove some old fdisk / diskabel /
bsdlabel invocations from the tree.

With those applied, for fdisk I see the following references
(excluding sbin/fdisk/* and comments, old examples, etc.):

contrib/netbsd-tests/sbin/gpt/t_gpt.sh
tests/sys/cddl/zfs/bin/zpool_smi.ksh

For bsdlabel / disklabel:

sbin/growfs/tests/legacy_test.pl
tools/regression/msdosfs/msdosfstest-2.sh
tools/regression/tmpfs/t_vnd
tools/tools/nanobsd/legacy.sh
contrib/netbsd-tests/kernel/t_umount.sh
contrib/netbsd-tests/kernel/t_umountstress.sh
contrib/netbsd-tests/sbin/gpt/t_gpt.sh
sbin/newfs/runtest00.sh
sbin/newfs/runtest01.sh

These will need to be addressed before actually removing any of these
binaries, of course.

> I wouldn't object to making these ports, but both these programs use 'sekret'
> bits from the kernel that might not remain exposed as we clean things up.
> Though the IOCTLs they do (or used to do) may no longer be relevant. It's
> been so long that I've forgotten....

If we eventually stop exporting those kernel interfaces the tools
would fail anyway, so IMO we can keep providing the kernel interfaces
along with the headers etc, and keep building from source until/unless
we drop support altogether.