From nobody Thu Jan 25 15:38:02 2024 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TLQ2d3xR6z57Tjm for ; Thu, 25 Jan 2024 15:38:17 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com [209.85.167.53]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TLQ2d22dqz4t9h for ; Thu, 25 Jan 2024 15:38:17 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-lf1-f53.google.com with SMTP id 2adb3069b0e04-50edf4f478eso8950655e87.3 for ; Thu, 25 Jan 2024 07:38:17 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706197095; x=1706801895; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=/FBYF6sPW3syARDw9aFjtg0w2y3mELypNAqAoe4ls+I=; b=hZVlY0IIRG45fzHmRvMCK5s3H71Knjfspm7/rI2tf/cR/cFhcFHtbHNgbcNVZSc3tY qQ3Z2FeqGC1oXeHmhHQvhmvrzVB88emJ1RA7ZE1u4VjQhFFSdtkuEu+miONmJ2SSZ+oV wlIM4RoxPbFLyF+DJbwz2tZJOKaK9Db3n2E9buc0Ww1Prci3n6aA69mvx2Q4simAj2M0 uBCFTdCAcugS8sOzst2k5UN2EW4paaF4P0CIWApC1LtuvzUDvbW+mob8BSioBaUP9K4t jD8yqiJX00/l6/K8sOSySd58aar6mnAgO1k6I4d/+2XLUJaAYfxHatmvRLDfvEYmB0fu M43g== X-Gm-Message-State: AOJu0YzTriI8UJ3RLEKv38YXOir0nnORx3NM0JSw2DnJOd4jkNr8C0rU 7bWAH7deRgLfwmjQ96KlDzagDvZms2jf6iVr6uPbt+JIXVSLTGwx1bM9OdIX3c9Q9W7saRkDMcL /6AigxfgwKa5PxiVxzUZHQnfEIjIQI1HXvVo= X-Google-Smtp-Source: AGHT+IGvY/xWTvSuSHqeRa51/B+8qOSb1kermTIedcOahhnYtQJw9EOGx330Hd4Zad3G9cvBgedSGqpkCgY3rhRWlCE= X-Received: by 2002:a05:6512:3ba7:b0:50e:7615:d34e with SMTP id g39-20020a0565123ba700b0050e7615d34emr869147lfv.22.1706197095030; Thu, 25 Jan 2024 07:38:15 -0800 (PST) List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org MIME-Version: 1.0 References: In-Reply-To: From: Ed Maste Date: Thu, 25 Jan 2024 10:38:02 -0500 Message-ID: Subject: Re: Removing fdisk and bsdlabel (legacy partition tools) To: Warner Losh Cc: FreeBSD Current Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4TLQ2d22dqz4t9h X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] On Wed, 24 Jan 2024 at 12:30, Warner Losh wrote: > > Those are the only users in the tree, but not for long :) I have some reviews open to remove some old fdisk / diskabel / bsdlabel invocations from the tree. With those applied, for fdisk I see the following references (excluding sbin/fdisk/* and comments, old examples, etc.): contrib/netbsd-tests/sbin/gpt/t_gpt.sh tests/sys/cddl/zfs/bin/zpool_smi.ksh For bsdlabel / disklabel: sbin/growfs/tests/legacy_test.pl tools/regression/msdosfs/msdosfstest-2.sh tools/regression/tmpfs/t_vnd tools/tools/nanobsd/legacy.sh contrib/netbsd-tests/kernel/t_umount.sh contrib/netbsd-tests/kernel/t_umountstress.sh contrib/netbsd-tests/sbin/gpt/t_gpt.sh sbin/newfs/runtest00.sh sbin/newfs/runtest01.sh These will need to be addressed before actually removing any of these binaries, of course. > I wouldn't object to making these ports, but both these programs use 'sekret' > bits from the kernel that might not remain exposed as we clean things up. > Though the IOCTLs they do (or used to do) may no longer be relevant. It's > been so long that I've forgotten.... If we eventually stop exporting those kernel interfaces the tools would fail anyway, so IMO we can keep providing the kernel interfaces along with the headers etc, and keep building from source until/unless we drop support altogether.