Re: RFC: NFS over TLS stats

From: Rick Macklem <rick.macklem_at_gmail.com>
Date: Thu, 26 Oct 2023 01:42:14 UTC 
On Wed, Oct 25, 2023 at 6:33 PM Simon J. Gerraty <sjg@juniper.net> wrote:
>
> Freddie Cash <fjwcash@gmail.com> wrote:
> > Have no technical comments, but a style suggestion:  put the tls at the end to make the output look nicer.  :)
> >
> > kern.rpctls.snd_msgbytes: 21508
> > kern.rpctls.snd_msgbytes_tls: 20828
> > kern.rpctls.snd_msgcnt: 58
> > kern.rpctls.snd_msgcnt_tls: 57
> > kern.rpctls.rcv_msgbytes: 12072
> > kern.rpctls.rcv_tmsgbytes_tls: 12336
> > kern.rpctls.rcv_msgcnt: 58
> > kern.rpctls.rcv_msgcnt_tls: 57
>
> FWIW I'd probably go the opposite way with
>
> kern.rpctls.tls.snd_msgbytes: 20828
> kern.rpctls.tls.snd_msgcnt: 57
> kern.rpctls.tls.rcv_tmsgbytes: 12336
> kern.rpctls.tls.rcv_msgcnt: 57
>
> which allows for sysctl kern.rpctls.tls
Not sure what you mean?
I am listing counts for TLS and non-TLS so they can
be compared. As such, a "tls" in the last component of
the name is needed, unless I list the non-TLS ones
under something else like:
kern.rpc.snd_msgbytes

I currently actually have them all as:
kern.rpc.tls.XXX instead of kern.rpctls.XXX,
since there was already kern.rpc.gss.XXX.

rick