From nobody Thu Oct 26 01:42:14 2023 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4SG7pB1bnGz4yKSd for ; Thu, 26 Oct 2023 01:42:26 +0000 (UTC) (envelope-from rick.macklem@gmail.com) Received: from mail-pj1-x1029.google.com (mail-pj1-x1029.google.com [IPv6:2607:f8b0:4864:20::1029]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4SG7p96r8fz4W7j for ; Thu, 26 Oct 2023 01:42:25 +0000 (UTC) (envelope-from rick.macklem@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-pj1-x1029.google.com with SMTP id 98e67ed59e1d1-27dc1e4d8b6so293820a91.0 for ; Wed, 25 Oct 2023 18:42:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698284544; x=1698889344; darn=freebsd.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=loFcAHDOqyLPeAuLd6MCHLn+2MkjuLlnsy+SDd7h/fY=; b=AiFXKlI6okYADr7sS0iTDfKO6p4B7atEtrGfFBdte+5rFvG5XfnNF79JWxeqBJgR7T 8utgcMUfWS0JsPUHg5umHDVMK6UYuTZDT6x0woaZ2TCLz/Z7zi6+/+bpOM04BKP+IMjM 0p0950VaxAwPj4sEQq862IWn7uh6z2nt4pBQcRnhnYMkQ1XmGKkQS1yieP1Zhx8wJTXK jBSDDPkmIk6l6USFcebJAkHL3AVYLBquBHZCLjEXdZ5Fg3yEM7vVwkDwiW1U7J8ZDbpO /G1XfKWpay9CwfMJK8uvyWoXAM+6VoeoyENcI1ZSqEh+6m0enQR+P4NCIXVbv/j2xVmW q5Qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698284544; x=1698889344; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=loFcAHDOqyLPeAuLd6MCHLn+2MkjuLlnsy+SDd7h/fY=; b=kiIlBcWhGnSfRgM8Hjb9ca8U5Y5JhjKoKbU5yu1KuQNjOfkwOMHJzszhlwIrM19gK9 rdBuMfhuhnOq/T43HSl4K7ExBXgMDdKVKFygxhYkTMAqIiFlrJFV5q7bDWlHUc+BbLGG PSYgGJys/dgPcnNoFFC4Vd7alrzeNuWSgQoWbBWPnFTKB/D8/aioe1UyLGJQJxxUAaq/ dNcZC6u6/xQ+De0/Tw++wzV2aUWBKo74Eado+NIF6fBVHchx9Jte54mWEJeXN6iILMOu m9o3xKynilajeY8ewWETka0cEwb8eISAKFuQZ5hP+rymyz7uifBPjO/Znm3CP5t0JBRP j/Mw== X-Gm-Message-State: AOJu0YzEDIhr9zz4Ivg3D0Z5qqqOtuFBEP7duiu0rdUYZIBZtzAJDvfm qhuMqwf35+oXwhTfM3xQKiz8FwupVuHC80V3ug== X-Google-Smtp-Source: AGHT+IEJofcf+OYDu0vlwDEwxqhapnUfHKaSqM3CJ7KVafJJtGN2wGjxEepkmHEg06g2BSIc7FvwgAvv5GPSEsYDB+k= X-Received: by 2002:a17:90b:f97:b0:27d:89d:2bc3 with SMTP id ft23-20020a17090b0f9700b0027d089d2bc3mr15221163pjb.3.1698284544588; Wed, 25 Oct 2023 18:42:24 -0700 (PDT) List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org MIME-Version: 1.0 References: <63874.1698283976@kaos.jnpr.net> In-Reply-To: <63874.1698283976@kaos.jnpr.net> From: Rick Macklem Date: Wed, 25 Oct 2023 18:42:14 -0700 Message-ID: Subject: Re: RFC: NFS over TLS stats To: "Simon J. Gerraty" Cc: Freddie Cash , FreeBSD CURRENT Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; TAGGED_FROM(0.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Rspamd-Queue-Id: 4SG7p96r8fz4W7j On Wed, Oct 25, 2023 at 6:33=E2=80=AFPM Simon J. Gerraty = wrote: > > Freddie Cash wrote: > > Have no technical comments, but a style suggestion: put the tls at the= end to make the output look nicer. :) > > > > kern.rpctls.snd_msgbytes: 21508 > > kern.rpctls.snd_msgbytes_tls: 20828 > > kern.rpctls.snd_msgcnt: 58 > > kern.rpctls.snd_msgcnt_tls: 57 > > kern.rpctls.rcv_msgbytes: 12072 > > kern.rpctls.rcv_tmsgbytes_tls: 12336 > > kern.rpctls.rcv_msgcnt: 58 > > kern.rpctls.rcv_msgcnt_tls: 57 > > FWIW I'd probably go the opposite way with > > kern.rpctls.tls.snd_msgbytes: 20828 > kern.rpctls.tls.snd_msgcnt: 57 > kern.rpctls.tls.rcv_tmsgbytes: 12336 > kern.rpctls.tls.rcv_msgcnt: 57 > > which allows for sysctl kern.rpctls.tls Not sure what you mean? I am listing counts for TLS and non-TLS so they can be compared. As such, a "tls" in the last component of the name is needed, unless I list the non-TLS ones under something else like: kern.rpc.snd_msgbytes I currently actually have them all as: kern.rpc.tls.XXX instead of kern.rpctls.XXX, since there was already kern.rpc.gss.XXX. rick