Re: cc_vegas isn't built in recent current

From: <tuexen_at_freebsd.org>
Date: Thu, 13 Jul 2023 20:33:59 UTC
> On 12. Jul 2023, at 14:42, void <void@f-m.fm> wrote:
> 
> Maybe the question I need to ask before asking about this is
> "what is the best tcp algo to use in the situation where:
> 
> 1. gigabit fibre on consumer FTTP
> 2. on a freebsd host whose purpose is hosting bhyve guests"
> 
> I expected to load cc_vegas as, from what I've read, it's the
Due to a bug, cc_vegas and a couple of other cc modules were
not build when they should. This is fixed in
https://cgit.FreeBSD.org/src/commit/?id=be78a31188c530c93700396ecfdb5604a8f22fff
> best (most responsive/throughput) for the context but the
> reading materials are from 2013 i think. 
> So, what's in the opinion of the list the best algo in the context?
> 
> The second thing is that cc_vegas doesn't build. Latest sources
> are main-264125. The OS is at n264089. The kld is missing because when world was built this kld obviously wasn't. I tried to build directly
> just now:
> 
> ##### snip
> # cd /usr/src/sys/modules/cc/cc_vegas
> # make
> Building /usr/obj/usr/src/amd64.amd64/sys/modules/cc/cc_vegas/machine
> machine -> /usr/src/sys/amd64/include
> Building /usr/obj/usr/src/amd64.amd64/sys/modules/cc/cc_vegas/x86
> x86 -> /usr/src/sys/x86/include
> Building /usr/obj/usr/src/amd64.amd64/sys/modules/cc/cc_vegas/i386
> i386 -> /usr/src/sys/i386/include
> Building /usr/obj/usr/src/amd64.amd64/sys/modules/cc/cc_vegas/opt_kern_tls.h
> Building /usr/obj/usr/src/amd64.amd64/sys/modules/cc/cc_vegas/opt_global.h
> Building /usr/obj/usr/src/amd64.amd64/sys/modules/cc/cc_vegas/cc_vegas.o
> /usr/src/sys/netinet/cc/cc_vegas.c:136:32: error: no member named 't_osd' in 'struct tcpcb'
>       e_t = khelp_get_osd(&CCV(ccv, t_osd), ertt_id);
>                                    ~~~~~~~~~^~~~~~
> /usr/src/sys/netinet/cc/cc_module.h:59:41: note: expanded from macro 'CCV'
>       #define CCV(ccv, what) (ccv)->ccvc.tcp->what
>                               ~~~~~~~~~~~~~~~  ^
>   1 error generated.
>   *** Error code 1
> 
> Stop.
> make: stopped in /usr/src/sys/modules/cc/cc_vegas
That is another bug. I plan to fix it once I figured out how to do this appropriately.

Best regards
Michael
> 
> ##### snip
> 
> -- 
>