From nobody Thu Jul 13 20:33:59 2023 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4R25tQ6nkqz4n8QD for ; Thu, 13 Jul 2023 20:34:06 +0000 (UTC) (envelope-from tuexen@freebsd.org) Received: from drew.franken.de (drew.ipv6.franken.de [IPv6:2001:638:a02:a001:20e:cff:fe4a:feaa]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.franken.de", Issuer "Sectigo RSA Domain Validation Secure Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4R25tP6tw6z3QYt for ; Thu, 13 Jul 2023 20:34:05 +0000 (UTC) (envelope-from tuexen@freebsd.org) Authentication-Results: mx1.freebsd.org; dkim=none; spf=softfail (mx1.freebsd.org: 2001:638:a02:a001:20e:cff:fe4a:feaa is neither permitted nor denied by domain of tuexen@freebsd.org) smtp.mailfrom=tuexen@freebsd.org; dmarc=none Received: from smtpclient.apple (unknown [IPv6:2a02:8109:1140:c3d:85a6:7e27:ddf8:905b]) (Authenticated sender: micmac) by mail-n.franken.de (Postfix) with ESMTPSA id 5376674E2726C; Thu, 13 Jul 2023 22:34:00 +0200 (CEST) Content-Type: text/plain; charset=us-ascii List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.600.7\)) Subject: Re: cc_vegas isn't built in recent current From: tuexen@freebsd.org In-Reply-To: Date: Thu, 13 Jul 2023 22:33:59 +0200 Cc: freebsd-current@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <62D10E0A-71B9-4498-93D7-227BCBE3040F@freebsd.org> References: To: void X-Mailer: Apple Mail (2.3731.600.7) X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00, T_SCC_BODY_TEXT_LINE autolearn=disabled version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on mail-n.franken.de X-Spamd-Result: default: False [-2.60 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-0.999]; MV_CASE(0.50)[]; MIME_GOOD(-0.10)[text/plain]; MLMMJ_DEST(0.00)[freebsd-current@freebsd.org]; FREEMAIL_TO(0.00)[f-m.fm]; ARC_NA(0.00)[]; R_DKIM_NA(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; ASN(0.00)[asn:680, ipnet:2001:638::/32, country:DE]; MIME_TRACE(0.00)[0:+]; FROM_NO_DN(0.00)[]; BLOCKLISTDE_FAIL(0.00)[2001:638:a02:a001:20e:cff:fe4a:feaa:server fail,2a02:8109:1140:c3d:85a6:7e27:ddf8:905b:server fail]; RCVD_COUNT_TWO(0.00)[2]; TO_DN_SOME(0.00)[]; FREEFALL_USER(0.00)[tuexen]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; MID_RHS_MATCH_FROM(0.00)[]; R_SPF_SOFTFAIL(0.00)[~all:c]; DMARC_NA(0.00)[freebsd.org]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_TLS_ALL(0.00)[] X-Rspamd-Queue-Id: 4R25tP6tw6z3QYt X-Spamd-Bar: -- X-ThisMailContainsUnwantedMimeParts: N > On 12. Jul 2023, at 14:42, void wrote: >=20 > Maybe the question I need to ask before asking about this is > "what is the best tcp algo to use in the situation where: >=20 > 1. gigabit fibre on consumer FTTP > 2. on a freebsd host whose purpose is hosting bhyve guests" >=20 > I expected to load cc_vegas as, from what I've read, it's the Due to a bug, cc_vegas and a couple of other cc modules were not build when they should. This is fixed in = https://cgit.FreeBSD.org/src/commit/?id=3Dbe78a31188c530c93700396ecfdb5604= a8f22fff > best (most responsive/throughput) for the context but the > reading materials are from 2013 i think.=20 > So, what's in the opinion of the list the best algo in the context? >=20 > The second thing is that cc_vegas doesn't build. Latest sources > are main-264125. The OS is at n264089. The kld is missing because when = world was built this kld obviously wasn't. I tried to build directly > just now: >=20 > ##### snip > # cd /usr/src/sys/modules/cc/cc_vegas > # make > Building /usr/obj/usr/src/amd64.amd64/sys/modules/cc/cc_vegas/machine > machine -> /usr/src/sys/amd64/include > Building /usr/obj/usr/src/amd64.amd64/sys/modules/cc/cc_vegas/x86 > x86 -> /usr/src/sys/x86/include > Building /usr/obj/usr/src/amd64.amd64/sys/modules/cc/cc_vegas/i386 > i386 -> /usr/src/sys/i386/include > Building = /usr/obj/usr/src/amd64.amd64/sys/modules/cc/cc_vegas/opt_kern_tls.h > Building = /usr/obj/usr/src/amd64.amd64/sys/modules/cc/cc_vegas/opt_global.h > Building = /usr/obj/usr/src/amd64.amd64/sys/modules/cc/cc_vegas/cc_vegas.o > /usr/src/sys/netinet/cc/cc_vegas.c:136:32: error: no member named = 't_osd' in 'struct tcpcb' > e_t =3D khelp_get_osd(&CCV(ccv, t_osd), ertt_id); > ~~~~~~~~~^~~~~~ > /usr/src/sys/netinet/cc/cc_module.h:59:41: note: expanded from macro = 'CCV' > #define CCV(ccv, what) (ccv)->ccvc.tcp->what > ~~~~~~~~~~~~~~~ ^ > 1 error generated. > *** Error code 1 >=20 > Stop. > make: stopped in /usr/src/sys/modules/cc/cc_vegas That is another bug. I plan to fix it once I figured out how to do this = appropriately. Best regards Michael >=20 > ##### snip >=20 > --=20 >=20