Re: compile failure in /usr/src/stand/libsa

In reply to: Gary Jennejohn : "compile failure in /usr/src/stand/libsa"
Go to: [ bottom of page ] [ top of archives ] [ this month ]

From: Toomas Soome via current <current_at_freebsd.org>
Date: Fri, 10 Sep 2021 11:50:59 UTC

> On 10. Sep 2021, at 13:53, Gary Jennejohn <gljennjohn@gmail.com> wrote:
> 
> So, a new problem with buildworld in HEAD.
> 
> Building in /usr/src/stand/libsa fails because dosfs.c, ufs.c and
> geli/gelidev.c can't find disk.h.  But disk.h is located in ../common.
> 
> I had to modify all three of these files to get the compile to finish
> by using ../common/disk.h.
> 
> In /usr/src/stand/defs.mk I find LDRSRC= ${BOOTSRC}/common and defs.mk
> is included in /usr/src/stand/Makefile.inc.  So it seems like the C-files
> under libsa should find the includes.
> 
> However, I'm not sure whether LDSRC is the correct value to be using
> in defs.mk, because I'm not sure what it means.
> 
> I saw this error on two different machines with the latst HEAD tree.
> 
> -- 
> Gary Jennejohn
> 

Could you paste the compiler command line used to build ufs.c for example?

I’m expecting to see something:
cc  -O2 -pipe -fno-common   -nostdinc    -I/usr/obj/usr/src/amd64.amd64/stand/libsa -I/usr/src/stand/libsa -D_STANDALONE -I/usr/src/sys -Ddouble=jagged-little-pill -Dfloat=floaty-mcfloatface -ffunction-sections -fdata-sections -DLOADER_GELI_SUPPORT -I/usr/src/stand/libsa/geli -DLOADER_DISK_SUPPORT -ffreestanding -mno-mmx -mno-sse -mno-avx -mno-avx2 -msoft-float -fPIC -mno-red-zone -mno-relax -I. -Iinclude -DBZ_NO_STDIO -DBZ_NO_COMPRESS -DHAVE_MEMCPY -I/usr/src/sys/contrib/zlib -I/usr/src/stand/common -DWEAK_REFS -DHAS_ZSTD_ZFS -I/usr/src/stand/common -I/usr/src/sys/cddl/boot/zfs -I/usr/src/sys/crypto/skein -I/usr/src/sys/contrib/openzfs/include -I/usr/src/sys/contrib/openzfs/include/os/freebsd/zfs -Wformat -Wall -g -gz=zlib -MD  -MF.depend.ufs.o -MTufs.o -std=gnu99 -Wno-format-zero-length -Wsystem-headers -Werror -Wno-pointer-sign -Wno-empty-body -Wno-string-plus-int -Wno-unused-const-variable -Wno-tautological-compare -Wno-unused-value -Wno-parentheses-equality -Wno-unused-function -Wno-enum-conversion -Wno-unused-local-typedef -Wno-address-of-packed-member -Wno-switch -Wno-switch-enum -Wno-knr-promoted-parameter -Wno-parentheses  -Oz -Qunused-arguments    -c /usr/src/stand/libsa/ufs.c -o ufs.o

rgds,
toomas