From nobody Fri Sep 10 11:50:59 2021 X-Original-To: current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id EA9CC17B8B92 for ; Fri, 10 Sep 2021 11:51:09 +0000 (UTC) (envelope-from tsoome@me.com) Received: from pv50p00im-ztdg10021101.me.com (pv50p00im-ztdg10021101.me.com [17.58.6.44]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4H5Z2j5d56z4kyp for ; Fri, 10 Sep 2021 11:51:09 +0000 (UTC) (envelope-from tsoome@me.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=me.com; s=1a1hai; t=1631274662; bh=rGhupYsLG7M+6rKCf20Yq+eeRVy2taDQumBGDyOZzdg=; h=From:Message-Id:Content-Type:Mime-Version:Subject:Date:To; b=wesNFjQAOAA+aXER2wUMZvVMXLjwvBqHvoW9vR/cJ8adkQOKVzJicsaRHzfliVtc9 I1r5JqyZgwYdIu4qJblldO7vFd8PuuPT7zFQoInxrFug9zCusek9/wTF4J5JnhkrEz L5xg7nvdlMwYkgarYoW6RegScy1TmW6F0ynJ4tlymPNea1j3RAp1zQxQXiwRHjd6I9 c6LiNoJzS7JnEh45az8+dKehokWpYO9aCZrhmWtBbmU3DVkyK+n90urTqt/wJCCtBl UYp3twGQ61tBRoF4sMS1e1wwNkAC3f9YSkeTDPXO757Ltbh9RxRidvGnafdf5ZfhGD TZSU19yGcapzg== Received: from smtpclient.apple (148-52-235-80.sta.estpak.ee [80.235.52.148]) by pv50p00im-ztdg10021101.me.com (Postfix) with ESMTPSA id DAE95180358; Fri, 10 Sep 2021 11:51:01 +0000 (UTC) Message-Id: <6B76ACF0-3896-49F4-8061-C1C94B850ADB@me.com> Content-Type: multipart/alternative; boundary="Apple-Mail=_2D482388-E716-47A9-9D8F-E9E38D97FC7D" List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\)) Subject: Re: compile failure in /usr/src/stand/libsa Date: Fri, 10 Sep 2021 14:50:59 +0300 In-Reply-To: <20210910105307.6fef0726@ernst.home> Cc: current@freebsd.org To: gljennjohn@gmail.com References: <20210910105307.6fef0726@ernst.home> X-Mailer: Apple Mail (2.3654.120.0.1.13) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391,18.0.790 definitions=2021-09-10_04:2021-09-09,2021-09-10 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-2009150000 definitions=main-2109100072 X-Rspamd-Queue-Id: 4H5Z2j5d56z4kyp X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] Reply-To: tsoome@me.com From: Toomas Soome via current X-Original-From: Toomas Soome X-ThisMailContainsUnwantedMimeParts: Y --Apple-Mail=_2D482388-E716-47A9-9D8F-E9E38D97FC7D Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On 10. Sep 2021, at 13:53, Gary Jennejohn = wrote: >=20 > So, a new problem with buildworld in HEAD. >=20 > Building in /usr/src/stand/libsa fails because dosfs.c, ufs.c and > geli/gelidev.c can't find disk.h. But disk.h is located in ../common. >=20 > I had to modify all three of these files to get the compile to finish > by using ../common/disk.h. >=20 > In /usr/src/stand/defs.mk I find LDRSRC=3D ${BOOTSRC}/common and = defs.mk > is included in /usr/src/stand/Makefile.inc. So it seems like the = C-files > under libsa should find the includes. >=20 > However, I'm not sure whether LDSRC is the correct value to be using > in defs.mk, because I'm not sure what it means. >=20 > I saw this error on two different machines with the latst HEAD tree. >=20 > --=20 > Gary Jennejohn >=20 Could you paste the compiler command line used to build ufs.c for = example? I=E2=80=99m expecting to see something: cc -O2 -pipe -fno-common -nostdinc = -I/usr/obj/usr/src/amd64.amd64/stand/libsa -I/usr/src/stand/libsa = -D_STANDALONE -I/usr/src/sys -Ddouble=3Djagged-little-pill = -Dfloat=3Dfloaty-mcfloatface -ffunction-sections -fdata-sections = -DLOADER_GELI_SUPPORT -I/usr/src/stand/libsa/geli -DLOADER_DISK_SUPPORT = -ffreestanding -mno-mmx -mno-sse -mno-avx -mno-avx2 -msoft-float -fPIC = -mno-red-zone -mno-relax -I. -Iinclude -DBZ_NO_STDIO -DBZ_NO_COMPRESS = -DHAVE_MEMCPY -I/usr/src/sys/contrib/zlib -I/usr/src/stand/common = -DWEAK_REFS -DHAS_ZSTD_ZFS -I/usr/src/stand/common = -I/usr/src/sys/cddl/boot/zfs -I/usr/src/sys/crypto/skein = -I/usr/src/sys/contrib/openzfs/include = -I/usr/src/sys/contrib/openzfs/include/os/freebsd/zfs -Wformat -Wall -g = -gz=3Dzlib -MD -MF.depend.ufs.o -MTufs.o -std=3Dgnu99 = -Wno-format-zero-length -Wsystem-headers -Werror -Wno-pointer-sign = -Wno-empty-body -Wno-string-plus-int -Wno-unused-const-variable = -Wno-tautological-compare -Wno-unused-value -Wno-parentheses-equality = -Wno-unused-function -Wno-enum-conversion -Wno-unused-local-typedef = -Wno-address-of-packed-member -Wno-switch -Wno-switch-enum = -Wno-knr-promoted-parameter -Wno-parentheses -Oz -Qunused-arguments = -c /usr/src/stand/libsa/ufs.c -o ufs.o rgds, toomas= --Apple-Mail=_2D482388-E716-47A9-9D8F-E9E38D97FC7D--