[Bug 273625] www/chromium: use base iconv

From: <bugzilla-noreply_at_freebsd.org>
Date: Fri, 15 Sep 2023 16:06:33 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=273625

--- Comment #2 from gnikl@justmail.de ---
@comment #1
> Yes you can build it with iconv support from libc.
Thank you for the confirmation. I just realized that my digging about the iconv
addition was incorrect. Linking with iconv was added with commit a23dfd2 to
base/BUILD.gn, commit bfedd5f moved the library reference to
third_party/maldoca/BUILD.gn.

> however the build will still link to libiconv because other dependencies will pull it in so my opinion is that it is best not to mix the two and just keep using libiconv.
That is a reasonable stance. Still, I am not sure that chromium must link with
iconv only because a dependency uses it. I checked the direct dependencies and
the "culprit" is devel/glib20. Since libiconv is available because of glib20
the chromium build process simply picks it up. I believe avoiding the libiconv
dependency with the help of LIBICONV_PLUG would be reasonable. However, the
decision how iconv should be handled, is your call.

-- 
You are receiving this mail because:
You are the assignee for the bug.