From nobody Fri Sep 15 16:06:33 2023 X-Original-To: chromium@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RnJw91dD9z4t2BB for ; Fri, 15 Sep 2023 16:06:33 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RnJw90NVFz4Ymq for ; Fri, 15 Sep 2023 16:06:33 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1694793993; a=rsa-sha256; cv=none; b=GjNmgTfqB4O2oNFoU9sw8v+5nEqUNeLvCd1qSCC3Kv+cjVKZmMRVVH47TF7funNCyABPBP WaoHiGJzTC1F1M7vDNcf011af8+ok1opbi52JC0w0mEpivfoRAcVC96m/8nmhEfbfMQRqw uhV7jMwq5JHk+scX6A1o4ubn4wHjL2l7/n1aBxy168l5iPk+irAMXCovZREFmBhshWr3uU YrmVXdym9+JQwmnT8Qrxe+QTtY2Fnz9cWwlwomhli0MW8YJyyvGzvP/27uMg98HpVU8waJ jmSTjlkRhXzDNIW5S4ldn6mSxS+Gql4sUoOntYmWT/ME/0V6RkRIY436rYWBvQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1694793993; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=u52clEzqcwXamn2oLlMsEaD460Idiu8T1h9bFwm+D5U=; b=pr9sACcAA/XE14MiJZu0bf8QgT+t/Mwc+G/I4so7irQHbMHda8Hdv9oRuT2jfsSso6aV6W MbRYYt3BQhKdY2dEY/G8Pexf9Pgl3ZZXVWTFa8qKAnWgiChfzRovr7IxpbQjll//sQ7EJF MtGWVQBtAH/fXm3rp4WO4NSc1adT7HeX5DWgCwPjXNSUim5lbJ7Gb54Gu51Ntqj0ziYQMa m+u8N7am0gXJkHnsEQJ0x2XEj/FFZSQLRvb1DaRk/vF9lPmURP9lmOwK/9/D7f0X+UpMOX vRFpRzTYx/iV78sImtqqHNVXE4s5wGBsZqMABvdZb1AFCTw7UGVlTzXHJEH/gA== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4RnJw86TkfzWf9 for ; Fri, 15 Sep 2023 16:06:32 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 38FG6WeT079265 for ; Fri, 15 Sep 2023 16:06:32 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 38FG6WoT079264 for chromium@FreeBSD.org; Fri, 15 Sep 2023 16:06:32 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: chromium@FreeBSD.org Subject: [Bug 273625] www/chromium: use base iconv Date: Fri, 15 Sep 2023 16:06:33 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: gnikl@justmail.de X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: chromium@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: FreeBSD-specific Chromium issues List-Archive: https://lists.freebsd.org/archives/freebsd-chromium List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-chromium@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D273625 --- Comment #2 from gnikl@justmail.de --- @comment #1 > Yes you can build it with iconv support from libc. Thank you for the confirmation. I just realized that my digging about the i= conv addition was incorrect. Linking with iconv was added with commit a23dfd2 to base/BUILD.gn, commit bfedd5f moved the library reference to third_party/maldoca/BUILD.gn. > however the build will still link to libiconv because other dependencies = will pull it in so my opinion is that it is best not to mix the two and jus= t keep using libiconv. That is a reasonable stance. Still, I am not sure that chromium must link w= ith iconv only because a dependency uses it. I checked the direct dependencies = and the "culprit" is devel/glib20. Since libiconv is available because of glib20 the chromium build process simply picks it up. I believe avoiding the libic= onv dependency with the help of LIBICONV_PLUG would be reasonable. However, the decision how iconv should be handled, is your call. --=20 You are receiving this mail because: You are the assignee for the bug.=