[Bug 191135] [hptrr] probe hptrr INQUIRY CDB: 12 00 00 00 24 00 CAM status: Invalid Target ID Error 22

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=191135

Warner Losh <imp@FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |imp@FreeBSD.org

--- Comment #3 from Warner Losh <imp@FreeBSD.org> ---
diff --git a/sys/dev/hptrr/hptrr_osm_bsd.c b/sys/dev/hptrr/hptrr_osm_bsd.c
index 42866c1d4297..78a051d54cf8 100644
--- a/sys/dev/hptrr/hptrr_osm_bsd.c
+++ b/sys/dev/hptrr/hptrr_osm_bsd.c
@@ -463,7 +463,7 @@ static void os_cmddone(PCOMMAND pCmd)
                ccb->ccb_h.status = CAM_BUSY;
                break;
        default:
-           ccb->ccb_h.status = CAM_SCSI_STATUS_ERROR;
+         ccb->ccb_h.status = CAM_AUTOSENSE_FAIL;
                break;
        }

@@ -557,7 +557,7 @@ static void hpt_scsi_io(PVBUS_EXT vbus_ext, union ccb *ccb)
                ccb->ccb_h.target_id >= osm_max_targets ||
                (ccb->ccb_h.flags & CAM_CDB_PHYS))
        {
-           ccb->ccb_h.status = CAM_TID_INVALID;
+         ccb->ccb_h.status = CAM_SEL_TIMEOUT;
                xpt_done(ccb);
                return;
        }

is the diff. I'm torn on committing it. This driver is super hard to test, has
binary elements and likely should be deleted in FreeBSD 15. So the above
compiles, and was also reported by jmg as working based on a tip from Scott
Long, which is a fairly decent provenance. But it's 10 years old now and nobody
has been complaining in the mean time. I came down on the side of committing
it, but no MFC unless we delete this driver.

-- 
You are receiving this mail because:
You are the assignee for the bug.