From nobody Wed Feb 05 01:31:03 2025 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YnjP3440Sz5mqdt for ; Wed, 05 Feb 2025 01:31:03 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YnjP33b7sz3nsk for ; Wed, 05 Feb 2025 01:31:03 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1738719063; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5ld3YBCeimtjmYvfg6lrhfAmb8iow3FVqxF2OycyqHQ=; b=MBSiDgdEq2ZZElz5VNlh6qy+dSvny6DMS9FtdVLfJo2j+iuz6A/+1vyPI1xMxVLMt9HFHZ x8x0osiuWddE5wyykEILM316HcwO3MjCeyov+7HskYfCf6srlnbf1l8NtsMMpML7QZsfrH LHIoCVF3wYTAvlNIcqRoU41D9o/wkB3+UBcsWHyImMjXDOoaQemfaZIhDXqAslCiQWl4/5 pQ8EFbj0ebV0cpLA+cdvrb9zCUOMHvcMARmBX9TuePncBclZeI5R/VgKnPPGdixKmayuq0 hIiUD3gutryhAKxNCzP9eric4YN/EasVBj7l17tRe/D8Js4YXNEJGD+hT5puQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1738719063; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5ld3YBCeimtjmYvfg6lrhfAmb8iow3FVqxF2OycyqHQ=; b=Qg8Z+DPeDd7aL0UFdQMkMuphcWbWEvCnDzp48kBfGRZA0LvPCl/x/s8KvEoXASpfgsxKPo hv+X7+FbiIvIYBfQ4Dl8iRrWOUYcFT/rAtGItXknjF66BRQmM88u1MrMr341kGj5/QnbNV TU+slZwCJ9Hi2YUlxOfCJEA4CrkBcJgfD9ercJyaip4QWu6wtsZQ0ExSx7erDCX8z4z72e gMxqLlfy2bF87m6/tTC/zQf5KsAb9kfbgti0NDQOM0IaeRpN90p2FOZRFEv6A3VIVl0P1P OyjsifhxwLtzTpmNw8nIkDcGhtsSMUky8HsyHFqd/FVvJCIU5WBC+qldcFwQEQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1738719063; a=rsa-sha256; cv=none; b=KpUik5keDEQhhlGtJKjh6RL83jJFjd1sE0y+z8VrNUKqtIH1oZpZeIK7+6UYn9//zmOnHA eSLMzJH8SnK1OhkBtgDiY/CNFCwb13OEGKDJDg6nzk/ohTtN1+c5vN6c8FbKPG49bY2G57 3VlgsQVNlLhoS1e8OLvfSvl9DDWO/fACnMXkpO06KwRgGhz+7v4NzAqjPZySWnhKTCJbPJ VsEPIwE5L70Ymw4pRZ7negZQcU4w31cyZb5JHNxnvG+SWX+qbxxoBTBkk6KChc8Tn3z4RJ 9Zt8WH4CaQGtqk+mfBc6rTXnCEz2S0SkN4hqQq+9TlUQ6vXjY9Fs2NZZJQRLJg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4YnjP336KwzVs6 for ; Wed, 05 Feb 2025 01:31:03 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 5151V3pn078719 for ; Wed, 5 Feb 2025 01:31:03 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 5151V3pF078718 for bugs@FreeBSD.org; Wed, 5 Feb 2025 01:31:03 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 191135] [hptrr] probe hptrr INQUIRY CDB: 12 00 00 00 24 00 CAM status: Invalid Target ID Error 22 Date: Wed, 05 Feb 2025 01:31:03 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 10.0-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: imp@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D191135 Warner Losh changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |imp@FreeBSD.org --- Comment #3 from Warner Losh --- diff --git a/sys/dev/hptrr/hptrr_osm_bsd.c b/sys/dev/hptrr/hptrr_osm_bsd.c index 42866c1d4297..78a051d54cf8 100644 --- a/sys/dev/hptrr/hptrr_osm_bsd.c +++ b/sys/dev/hptrr/hptrr_osm_bsd.c @@ -463,7 +463,7 @@ static void os_cmddone(PCOMMAND pCmd) ccb->ccb_h.status =3D CAM_BUSY; break; default: - ccb->ccb_h.status =3D CAM_SCSI_STATUS_ERROR; + ccb->ccb_h.status =3D CAM_AUTOSENSE_FAIL; break; } @@ -557,7 +557,7 @@ static void hpt_scsi_io(PVBUS_EXT vbus_ext, union ccb *= ccb) ccb->ccb_h.target_id >=3D osm_max_targets || (ccb->ccb_h.flags & CAM_CDB_PHYS)) { - ccb->ccb_h.status =3D CAM_TID_INVALID; + ccb->ccb_h.status =3D CAM_SEL_TIMEOUT; xpt_done(ccb); return; } is the diff. I'm torn on committing it. This driver is super hard to test, = has binary elements and likely should be deleted in FreeBSD 15. So the above compiles, and was also reported by jmg as working based on a tip from Scott Long, which is a fairly decent provenance. But it's 10 years old now and no= body has been complaining in the mean time. I came down on the side of committing it, but no MFC unless we delete this driver. --=20 You are receiving this mail because: You are the assignee for the bug.=