[Bug 212841] getting panic during mps reinitialization.

From: <bugzilla-noreply_at_freebsd.org>
Date: Wed, 16 Oct 2024 14:32:37 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=212841

--- Comment #14 from commit-hook@FreeBSD.org ---
A commit in branch stable/14 references this bug:

URL:
https://cgit.FreeBSD.org/src/commit/?id=b57229a80465b390a31fb30b3127c4cb93d8987f

commit b57229a80465b390a31fb30b3127c4cb93d8987f
Author:     prateek sethi <prateekrootkey@gmail.com>
AuthorDate: 2024-10-13 18:38:54 +0000
Commit:     Warner Losh <imp@FreeBSD.org>
CommitDate: 2024-10-16 14:19:21 +0000

    mps/mpr: Add workaround for firmware not responding to IOC_FACTS or
IOC_INIT

    Sometimes, especially with older firmware, mps(4) would have trouble
    initializing the card in one of these two steps. Add in a retry after a
    short delay. Sean Bruno and Stephen McConnell thought this was OK in the
    bug discussions, but never committed it.  Steve indicated the delay
    might not be necessary, but the OP clearly needed to make it longer to
    make things work. I've kept the delay, and added the suggested comment.

    Ported the iocfacts part to mpr as well, since we see similar errors
    about once every month or two over a few thousand controllers at
    work. We've not seen it with IOC_INIT as far back as I can query the
    error log database, so I didn't port that forward. We'll see if this
    helps, but won't know for sure until next year (so I'm committing it now
    since it won't hurt and might help). We usually see this failure in
    connection with complicated recovery operations with a drive that's
    failing, though, at least in the last year's worth of failures. It's
    not clear this is the same as OP or not.

    PR: 212841
    Sponsored by: Netflix
    Co-authored-by: imp

    (cherry picked from commit c0e0e530ced057502f51d7a6086857305e08fae0)

 sys/dev/mpr/mpr.c | 23 ++++++++++++++++++-----
 sys/dev/mps/mps.c | 38 ++++++++++++++++++++++++++++++--------
 2 files changed, 48 insertions(+), 13 deletions(-)

-- 
You are receiving this mail because:
You are the assignee for the bug.