From nobody Wed Oct 16 14:32:37 2024 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XTD2Z6zlvz5YbCb for ; Wed, 16 Oct 2024 14:32:38 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XTD2Z220Hz4SYT for ; Wed, 16 Oct 2024 14:32:38 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1729089158; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lXZ1n0ws2X/5HdArI9uZo4nVazcTIj1b5iXZdypUBhI=; b=O2CzK4ACOWxYuP/3XzXgPjCOIMp35hTMiBR0SFL5cl57NiAprX/LX+m4oIlGa+uRfbdHno sQnt7xkKa0BPL8SW6p8YRxQBNbJx/c3MnwpynpuRDo7bZTLeOEJbZd1wWbC/KVZzDxJmbw V8lmQH9D4tkpabGa7xhvdColrc6lGRZl4GUKZm0dBwGs9K15vCNVYprb8yF2tssKj0spUm Opoqhd4Hphx85eYh2s+hZ8WkKERFzHHz+Y0xQqU7jr0liELK63RvYB/Eqxm9WaDaVbYypN 1DCade35zWptxcAQ9lqpVZ5TJlfnp8gxTwAcPzyVfS9nJ2cHYvOd68SYYPPRKw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1729089158; a=rsa-sha256; cv=none; b=R5q6R60l7IFQtza9ITkc7dGGI9VwQeQh78TyMOoyci2eD05ElouwTO/kIusrMl8vVRNf9O QfB4DJ7qa9q/zfhy9lsOkinaVGMCyza5iG/dZ3jHUOIWrZroQj4bbLv66iIVIug9GlwIX+ M90LCxcb9SVYkSSwfpxMg/60Uz51AxoqDiyLGy48GTHunMAvbdR0M0Pmz5sMfH6fGiN+V6 /JQIytwJY7FmeuwWbtakudQUaP4A6U4OvSfWvbWjbS9WHl6jofIh91M8ZrjOBd8HS7WHt3 rd2yHlBj1DO4dIYs6zwnZpxUbrJcIqzgW3Bx+rrXn6kMGlguRNbZItVFcf+G8g== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4XTD2Z0SBfz18wl for ; Wed, 16 Oct 2024 14:32:38 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 49GEWb5A075846 for ; Wed, 16 Oct 2024 14:32:37 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 49GEWbBr075845 for bugs@FreeBSD.org; Wed, 16 Oct 2024 14:32:37 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 212841] getting panic during mps reinitialization. Date: Wed, 16 Oct 2024 14:32:37 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 9.2-RELEASE X-Bugzilla-Keywords: crash X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: mfc-stable14+ mfc-stable13+ X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D212841 --- Comment #14 from commit-hook@FreeBSD.org --- A commit in branch stable/14 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3Db57229a80465b390a31fb30b3127c4cb9= 3d8987f commit b57229a80465b390a31fb30b3127c4cb93d8987f Author: prateek sethi AuthorDate: 2024-10-13 18:38:54 +0000 Commit: Warner Losh CommitDate: 2024-10-16 14:19:21 +0000 mps/mpr: Add workaround for firmware not responding to IOC_FACTS or IOC_INIT Sometimes, especially with older firmware, mps(4) would have trouble initializing the card in one of these two steps. Add in a retry after a short delay. Sean Bruno and Stephen McConnell thought this was OK in the bug discussions, but never committed it. Steve indicated the delay might not be necessary, but the OP clearly needed to make it longer to make things work. I've kept the delay, and added the suggested comment. Ported the iocfacts part to mpr as well, since we see similar errors about once every month or two over a few thousand controllers at work. We've not seen it with IOC_INIT as far back as I can query the error log database, so I didn't port that forward. We'll see if this helps, but won't know for sure until next year (so I'm committing it now since it won't hurt and might help). We usually see this failure in connection with complicated recovery operations with a drive that's failing, though, at least in the last year's worth of failures. It's not clear this is the same as OP or not. PR: 212841 Sponsored by: Netflix Co-authored-by: imp (cherry picked from commit c0e0e530ced057502f51d7a6086857305e08fae0) sys/dev/mpr/mpr.c | 23 ++++++++++++++++++----- sys/dev/mps/mps.c | 38 ++++++++++++++++++++++++++++++-------- 2 files changed, 48 insertions(+), 13 deletions(-) --=20 You are receiving this mail because: You are the assignee for the bug.=