[Bug 269770] libalias udp redirect_port temporary translation failure

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=269770

--- Comment #8 from Peter Much <pmc@citylink.dinoex.sub.org> ---
Created attachment 252840
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=252840&action=edit
workaround/fix

In libalias/alias_db.c:_FindLinkIn() is a search for a temporary
(fully specified) flow, and on success it does
        return (UseLink(la, lnk));
Further down in this function is another search for a permanent
(partially specified) portforward.

If we return through UseLink(), this then does
        CleanupLink(la, &lnk, 0)
and there is a check for expiry, and then
        DeleteLink(lnk, ...)
So from there, if the link is expired, we get a NULL back, and the
permanent portforward is not searched for.

I fix this by delaying the CleanupLink() invocation to after the
permanent link has been searched for. And since this would add another
search on potentially every packet, I delay it only if the temporary
link has expired.

-- 
You are receiving this mail because:
You are the assignee for the bug.