From nobody Sat Aug 17 10:41:38 2024 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WmFll5n9Qz5Sn6p for ; Sat, 17 Aug 2024 10:41:39 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WmFll4mK9z4RBK for ; Sat, 17 Aug 2024 10:41:39 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1723891299; a=rsa-sha256; cv=none; b=Xn6HVV3Lw//jgMi1GmqAG2/bBWG/YEHL+YCgvvB/2nGbeXmtw4VqnkqRlNhMS7gadRHSBr GSYeAFent6mApCeg3HQSu2jHQ6nGEauAjAexp3VYbuoF7jwNjlnjm+ohT+nxtLG9nFNyOY 1Pe1HZuukQcC74fSxCwZSHyE+q3HvgMLx/DFlqaeq+eStbtU1RY9Dxha5NzTLF80QD86FS +mKZjgm8PB5WkHl2NZuSNs5B854D/v782a/0yw/dtHHPI5oTcyzH31XV9ezC7FhdzbDTLB W9miR2uU+H5Li3roSElphxpeP88Ef5esPXzVU3d2Q9jHkDKJYitKfIQpUJ4UhA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1723891299; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7UVnPBwjzJnJxJqFCio6yUgTup/N9ASS2KYze8RAQvc=; b=VuRsv3NFKX5lP91hqmkPnV/Xxy4zmT35PUHJSA8U49yS7AFhZ3cyLeKFH8B2N5cctguhRM qnkMLVa46XzjgjiqI21UuMUO4NiKj+0oNsTd9BEXlajKhCt6Hho3DMMeDqu0YeYXnlAZy1 Vt+Xem3QdpkhJknQCcfCFVffEmY/mUOC6BVmkt7Mr3fXDG3pxV3yNA91/+br2OVR+bY7Ai LyTSMsBfErX3VsJNnPCTYkdJOj0O20PdhV5bx6se/eXY2RIrTYICM83K7E47WGOqu8y7zj JB52qvv85gUDGRREhLYXDfIqHdJ2jy55AhEGACBu63EhBNiXN9+8bBbj5amdIQ== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WmFll4GrgzmN2 for ; Sat, 17 Aug 2024 10:41:39 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 47HAfdgn054020 for ; Sat, 17 Aug 2024 10:41:39 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 47HAfdMf054018 for bugs@FreeBSD.org; Sat, 17 Aug 2024 10:41:39 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 269770] libalias udp redirect_port temporary translation failure Date: Sat, 17 Aug 2024 10:41:38 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 13.1-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: pmc@citylink.dinoex.sub.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: attachments.created Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D269770 --- Comment #8 from Peter Much --- Created attachment 252840 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D252840&action= =3Dedit workaround/fix In libalias/alias_db.c:_FindLinkIn() is a search for a temporary (fully specified) flow, and on success it does return (UseLink(la, lnk)); Further down in this function is another search for a permanent (partially specified) portforward. If we return through UseLink(), this then does CleanupLink(la, &lnk, 0) and there is a check for expiry, and then DeleteLink(lnk, ...) So from there, if the link is expired, we get a NULL back, and the permanent portforward is not searched for. I fix this by delaying the CleanupLink() invocation to after the permanent link has been searched for. And since this would add another search on potentially every packet, I delay it only if the temporary link has expired. --=20 You are receiving this mail because: You are the assignee for the bug.=