Re: ALPHA1 on Raspberry Pi 3B+ [added: and RPi4B]

On Mon, 14 Aug 2023 07:03:19 +0200
Emmanuel Vadot <manu@bidouilliste.com> wrote:

> On Sun, 13 Aug 2023 12:35:31 -0500
> Mike Karels <mike@karels.net> wrote:
> 
> > On 13 Aug 2023, at 12:19, Emmanuel Vadot wrote:
> > 
> > > On Sun, 13 Aug 2023 11:25:25 -0500
> > > Mike Karels <mike@karels.net> wrote:
> > >
> > >> On 13 Aug 2023, at 11:10, Mark Millard wrote:
> > >>
> > >>> On Aug 13, 2023, at 08:17, Warner Losh <imp@bsdimp.com> wrote:
> > >>>
> > >>>> Manu just updated Linux DTS in the tree. Maybe see if you revert that if the problem persists.
> > >>>
> > >>> git: 69f8cc60aa1e - main - ofw_firmware: Only match if there is no compatible
> > >>>
> > >>> is the fix that Manu has committed:
> > >>>
> > >>> QUOTE
> > >>>     ofw_firmware: Only match if there is no compatible
> > >>>
> > >>>     If there is a compatible string it likely means that the firmware needs
> > >>>     a dedicated driver (like on RPI*).
> > >>>
> > >>>     PR:     273087
> > >>>     Tested-by:      Mark Millard <marklmi26-fbsd@yahoo.com>
> > >>>     Sponsored by:   Beckhoff Automation GmbH & Co. KG
> > >>>     Fixes:          fdfd3a90b6ce ("ofw: Add a ofw_firmware driver")
> > >>> END QUOTE
> > >>
> > >> Just for completeness: that change fixes the bcm2835_cpufreq0/powerd
> > >> problem and the gpioled0 problem, but not the clk_fixed2 problem
> > >> (clk_fixed4 on rpi4).  Installing an msdos boot partition from the
> > >> 3 Aug image makes that problem disappear.
> > >>
> > >> 		Mike
> > >
> > >  There is two fixed-clock in the DTB without clock-frequency property
> > > and with a status set to "disabled", this isn't conforming to the
> > > bindings
> > > (https://cgit.freebsd.org/src/tree/sys/contrib/device-tree/Bindings/clock/fixed-clock.yaml)
> > > so we complain on this, this is normal.
> > 
> > Would it be possible to detect the disabled status to prevent the errors
> > (I'm guessing not) or to suppress the repeats?  150 lines of errors seems
> > like a lot for an out-of-spec DTB entry, and makes it hard to ignore.
> > 
> > 		Mike
> 
>  Detecting the disabled status makes no sense, a fixed clock cannot be
> disable, it's always present and running.
>  But I think that if we check that clock-frenquency isn't present in
> the probe function, print a message and bail we will not attempt to
> attach the driver at each pass.
>  That's the only clean solution that I can see without making dirty
> hacks for some non-conforming DTB.

 Something like this :
https://people.freebsd.org/~manu/0001-clk-fixed-Bail-early-if-there-is-no-clock-frequency-.patch

 Please let me know if that works.

 Cheers,

-- 
Emmanuel Vadot <manu@bidouilliste.com> <manu@freebsd.org>