From nobody Mon Aug 14 05:30:25 2023 X-Original-To: freebsd-arm@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RPNK11rSDz4mPDp for ; Mon, 14 Aug 2023 05:30:29 +0000 (UTC) (envelope-from manu@bidouilliste.com) Received: from mx.blih.net (mx.blih.net [212.83.155.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mx.blih.net", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RPNJz5WRkz3QmQ for ; Mon, 14 Aug 2023 05:30:27 +0000 (UTC) (envelope-from manu@bidouilliste.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bidouilliste.com header.s=mx header.b=KmhHn2BA; spf=pass (mx1.freebsd.org: domain of manu@bidouilliste.com designates 212.83.155.74 as permitted sender) smtp.mailfrom=manu@bidouilliste.com; dmarc=pass (policy=none) header.from=bidouilliste.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bidouilliste.com; s=mx; t=1691991025; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jH9rArbvUVFk27wGY7VlpYJJpJJbXnSr7aelGwBbf5U=; b=KmhHn2BAZP77nM3gm1XUFztg43cTijEcF0x6ISowwsJg6k7ZTMS0oCxkUwnOLmXhvoM3uL ryivEbo3vPCqjsy2FFAbWtwUJVOeOZuO6/COG+t2gcr1nnb0tHR/YFu0SxdXHkq0UWE51Q HImggCg8lI3wPCVAJtLp4V6jqe4ovwU= Received: from skull.home.blih.net (lfbn-lyo-1-2174-135.w90-66.abo.wanadoo.fr [90.66.97.135]) by mx.blih.net (OpenSMTPD) with ESMTPSA id a78f12e3 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Mon, 14 Aug 2023 05:30:25 +0000 (UTC) Date: Mon, 14 Aug 2023 07:30:25 +0200 From: Emmanuel Vadot To: Mike Karels , freebsd-arm Subject: Re: ALPHA1 on Raspberry Pi 3B+ [added: and RPi4B] Message-Id: <20230814073025.c06a3d2fe2c766b179ab6d0c@bidouilliste.com> In-Reply-To: <20230814070319.1d04005ae92b8c0bc0ccf025@bidouilliste.com> References: <1C94FEAF-C616-498F-8562-2E99CF12417D@edc.ro> <4F7960AE-F607-4FEF-8A02-2013862A37E3@yahoo.com> <20230813191924.1b9b7927f0d98ce9937a571f@bidouilliste.com> <20230814070319.1d04005ae92b8c0bc0ccf025@bidouilliste.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; amd64-portbld-freebsd14.0) List-Id: Porting FreeBSD to ARM processors List-Archive: https://lists.freebsd.org/archives/freebsd-arm List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-arm@freebsd.org Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spamd-Result: default: False [-3.36 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.96)[-0.962]; MV_CASE(0.50)[]; DMARC_POLICY_ALLOW(-0.50)[bidouilliste.com,none]; R_DKIM_ALLOW(-0.20)[bidouilliste.com:s=mx]; R_SPF_ALLOW(-0.20)[+ip4:212.83.155.74/32]; MIME_GOOD(-0.10)[text/plain]; ONCE_RECEIVED(0.10)[]; RCVD_TLS_ALL(0.00)[]; MIME_TRACE(0.00)[0:+]; MLMMJ_DEST(0.00)[freebsd-arm@freebsd.org]; FROM_EQ_ENVFROM(0.00)[]; RCVD_COUNT_ONE(0.00)[1]; ASN(0.00)[asn:12876, ipnet:212.83.128.0/19, country:FR]; DKIM_TRACE(0.00)[bidouilliste.com:+]; MID_RHS_MATCH_FROM(0.00)[]; FREEFALL_USER(0.00)[manu]; ARC_NA(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; FROM_HAS_DN(0.00)[]; TO_DN_ALL(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[] X-Spamd-Bar: --- X-Rspamd-Queue-Id: 4RPNJz5WRkz3QmQ On Mon, 14 Aug 2023 07:03:19 +0200 Emmanuel Vadot wrote: > On Sun, 13 Aug 2023 12:35:31 -0500 > Mike Karels wrote: > > > On 13 Aug 2023, at 12:19, Emmanuel Vadot wrote: > > > > > On Sun, 13 Aug 2023 11:25:25 -0500 > > > Mike Karels wrote: > > > > > >> On 13 Aug 2023, at 11:10, Mark Millard wrote: > > >> > > >>> On Aug 13, 2023, at 08:17, Warner Losh wrote: > > >>> > > >>>> Manu just updated Linux DTS in the tree. Maybe see if you revert that if the problem persists. > > >>> > > >>> git: 69f8cc60aa1e - main - ofw_firmware: Only match if there is no compatible > > >>> > > >>> is the fix that Manu has committed: > > >>> > > >>> QUOTE > > >>> ofw_firmware: Only match if there is no compatible > > >>> > > >>> If there is a compatible string it likely means that the firmware needs > > >>> a dedicated driver (like on RPI*). > > >>> > > >>> PR: 273087 > > >>> Tested-by: Mark Millard > > >>> Sponsored by: Beckhoff Automation GmbH & Co. KG > > >>> Fixes: fdfd3a90b6ce ("ofw: Add a ofw_firmware driver") > > >>> END QUOTE > > >> > > >> Just for completeness: that change fixes the bcm2835_cpufreq0/powerd > > >> problem and the gpioled0 problem, but not the clk_fixed2 problem > > >> (clk_fixed4 on rpi4). Installing an msdos boot partition from the > > >> 3 Aug image makes that problem disappear. > > >> > > >> Mike > > > > > > There is two fixed-clock in the DTB without clock-frequency property > > > and with a status set to "disabled", this isn't conforming to the > > > bindings > > > (https://cgit.freebsd.org/src/tree/sys/contrib/device-tree/Bindings/clock/fixed-clock.yaml) > > > so we complain on this, this is normal. > > > > Would it be possible to detect the disabled status to prevent the errors > > (I'm guessing not) or to suppress the repeats? 150 lines of errors seems > > like a lot for an out-of-spec DTB entry, and makes it hard to ignore. > > > > Mike > > Detecting the disabled status makes no sense, a fixed clock cannot be > disable, it's always present and running. > But I think that if we check that clock-frenquency isn't present in > the probe function, print a message and bail we will not attempt to > attach the driver at each pass. > That's the only clean solution that I can see without making dirty > hacks for some non-conforming DTB. Something like this : https://people.freebsd.org/~manu/0001-clk-fixed-Bail-early-if-there-is-no-clock-frequency-.patch Please let me know if that works. Cheers, -- Emmanuel Vadot