Re: sys/modules/Makefile and MACHINE_ARCH vs arm64 (in use) vs aarch64 (not in use) VS. man arch; also COMPAT_FREEBSD32_ENABLED use

From: Warner Losh <imp_at_bsdimp.com>
Date: Wed, 02 Aug 2023 18:16:40 UTC
Those all look wrong to me.

Warner

On Wed, Aug 2, 2023, 11:27 AM Mark Millard <marklmi@yahoo.com> wrote:

> man arch reports:
>
>            MACHINE       MACHINE_CPUARCH       MACHINE_ARCH
>            arm64         aarch64               aarch64
> . . .
>            arm           arm                   armv6, armv7
>
> So I'd not expect arm64 in MACHINE_ARCH . But
> sys/modules/Makefile has (from a grep for MACHINE_ARCH):
>
> .if ${MACHINE_ARCH} == "amd64" || ${MACHINE_ARCH} == "arm64"
> .if ${MACHINE_ARCH} == "amd64" || ${MACHINE_ARCH} == "arm64" ||
> ${MACHINE_ARCH:Mpowerpc64*}
>
>
> Another issue may be that COMPAT_FREEBSD32_ENABLED is only
> put to use in the Makefile for MACHINE_CPUARCH being i386
> or amd64 :
>
> .if ${MACHINE_CPUARCH} == "i386" || ${MACHINE_CPUARCH} == "amd64"
> _agp=           agp
> .if ${MACHINE_CPUARCH} == "i386" || !empty(COMPAT_FREEBSD32_ENABLED)
> . . .
>
>
>
>
> ===
> Mark Millard
> marklmi at yahoo.com
>
>