git: 2d4219919a48 - main - acpi_gpiobus: Narrow scope of NOT_YET

From: Colin Percival <cperciva_at_FreeBSD.org>
Date: Sat, 26 Oct 2024 02:35:13 UTC
The branch main has been updated by cperciva:

URL: https://cgit.FreeBSD.org/src/commit/?id=2d4219919a48aa6d67ae62e2b8859ffe3b035bd2

commit 2d4219919a48aa6d67ae62e2b8859ffe3b035bd2
Author:     Colin Percival <cperciva@FreeBSD.org>
AuthorDate: 2024-10-22 18:25:11 +0000
Commit:     Colin Percival <cperciva@FreeBSD.org>
CommitDate: 2024-10-26 02:34:57 +0000

    acpi_gpiobus: Narrow scope of NOT_YET
    
    GPIO interrupts work just fine and will be used shortly.  We still
    do not support GPIO_INTR_SHAREABLE however, so leave that within
    the NOT_YET scope.
    
    Reviwed by:     andrew
    MFC after:      1 week
    Sponsored by:   Amazon
    Differential Revision:  https://reviews.freebsd.org/D47251
---
 sys/dev/gpio/acpi_gpiobus.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/sys/dev/gpio/acpi_gpiobus.c b/sys/dev/gpio/acpi_gpiobus.c
index 3b6fc6dde674..9828170daeca 100644
--- a/sys/dev/gpio/acpi_gpiobus.c
+++ b/sys/dev/gpio/acpi_gpiobus.c
@@ -52,8 +52,6 @@ acpi_gpiobus_convflags(ACPI_RESOURCE_GPIO *gpio_res)
 	uint32_t flags = 0;
 
 	/* Figure out pin flags */
-#ifdef NOT_YET
-	/* These are currently unused. */
 	if (gpio_res->ConnectionType == ACPI_RESOURCE_GPIO_TYPE_INT) {
 		switch (gpio_res->Polarity) {
 		case ACPI_ACTIVE_HIGH:
@@ -69,10 +67,12 @@ acpi_gpiobus_convflags(ACPI_RESOURCE_GPIO *gpio_res)
 			break;
 		}
 
+#ifdef NOT_YET
+		/* This is not currently implemented. */
 		if (gpio_res->Shareable == ACPI_SHARED)
 			flags |= GPIO_INTR_SHAREABLE;
-	}
 #endif
+	}
 	switch (gpio_res->IoRestriction) {
 	case ACPI_IO_RESTRICT_INPUT:
 		flags |= GPIO_PIN_INPUT;