From nobody Sat Oct 26 02:35:13 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Xb3f94thpz5bQPs; Sat, 26 Oct 2024 02:35:13 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Xb3f91cvJz4S5G; Sat, 26 Oct 2024 02:35:13 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1729910113; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=/lwbZmlBoq9bFvhhI5l1MS4A4xeByGTJe+md0YxA7RQ=; b=gHEqGAJ4xfPYIpL//ETNOQt5/1ohTMeqpiyAkrdQPjg9DZd0EgNsLw7KVHRLJcpp2bQR7M 3koDwV6qq2ljZuV1y27bIGmiLki/210m5o1jwzXwbEMqo2kB/p7/eLNrEstXdfRqqcFvQ8 AjxFu53phWtPxWCEraJDwJfInUiqQgDmK9ngro0BEiaCkMVlUxRakJABjnc2315lDI55+w ITcNCC6YZnxa78DQ8+DowGLiYqTBSYo0f7bFvssy0mqFKhnP4cxqTcTcByin7uGImh0Z/y /gkMayG7xbiG/DIxZUXUZTosgsdlc+IqPnlAlvE+13GgFiROUKBHzcHtiKTeLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1729910113; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=/lwbZmlBoq9bFvhhI5l1MS4A4xeByGTJe+md0YxA7RQ=; b=EoFfrH48I8qyGL7paSj2Y6HajtJ5RFCefxrwklausyhhpuhwNFxT026d1S/p1/4zC9Lqop z9Xwq+gQEuQV4EOBAaWN0Y7vRHt1UFgWFHS0I1kpBccA50XtdIjICanHcpvKp3LHU1NG+b e/vbIDMc6KTG9iA3fLV5FTmlExDYFPStNSr4BMdC/b0Cku9iLFbmtxnKuTC7DNDgqDMtIt dRUUiAirBHQToti8zzgI3q0Y+JKhdw0SPtNooLXb5nlJ9XvLmDWqS88XXpmxcL+V0UvIqr ZRh8JEKF7uADeBlk89V3wI2yh8ybJvbvxhjnzp37/FHZDvCNm2f4u6r3yu17cA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1729910113; a=rsa-sha256; cv=none; b=J10h7ZTU6Shpp1MaSnpJTrPEnuvyHBDAsqmomCsbfGLwQ0+UosOej43rcujzJ7vFbfEZB6 vvGhhX40mlxK7LT1zaxXNFU6MxXjOn/6b89skUpu/iyXdRQ8NuDfeOrrdoKSftQh9mq6/Z XJ95EhlyZpdugX1swKpxSxxPJE8RPmZu7WoNcyp1j/rZKnES3sYyFIVvYvCZJU0SWcPUuU ne0/k3njZKhZght8GUOq6kn0FAae8tFyZMaGcZiaOiDjYIFbLSIoI4fXjncVM0MBrSRBAj QilC5ND1ahzusvbJeuWEn5DGG4WHJgLvcZbq5NzKbv2BOlgRUAw1ix0HyAPRGw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Xb3f90qhCzrY0; Sat, 26 Oct 2024 02:35:13 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 49Q2ZDRx007599; Sat, 26 Oct 2024 02:35:13 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 49Q2ZDMu007596; Sat, 26 Oct 2024 02:35:13 GMT (envelope-from git) Date: Sat, 26 Oct 2024 02:35:13 GMT Message-Id: <202410260235.49Q2ZDMu007596@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Colin Percival Subject: git: 2d4219919a48 - main - acpi_gpiobus: Narrow scope of NOT_YET List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: cperciva X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 2d4219919a48aa6d67ae62e2b8859ffe3b035bd2 Auto-Submitted: auto-generated The branch main has been updated by cperciva: URL: https://cgit.FreeBSD.org/src/commit/?id=2d4219919a48aa6d67ae62e2b8859ffe3b035bd2 commit 2d4219919a48aa6d67ae62e2b8859ffe3b035bd2 Author: Colin Percival AuthorDate: 2024-10-22 18:25:11 +0000 Commit: Colin Percival CommitDate: 2024-10-26 02:34:57 +0000 acpi_gpiobus: Narrow scope of NOT_YET GPIO interrupts work just fine and will be used shortly. We still do not support GPIO_INTR_SHAREABLE however, so leave that within the NOT_YET scope. Reviwed by: andrew MFC after: 1 week Sponsored by: Amazon Differential Revision: https://reviews.freebsd.org/D47251 --- sys/dev/gpio/acpi_gpiobus.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sys/dev/gpio/acpi_gpiobus.c b/sys/dev/gpio/acpi_gpiobus.c index 3b6fc6dde674..9828170daeca 100644 --- a/sys/dev/gpio/acpi_gpiobus.c +++ b/sys/dev/gpio/acpi_gpiobus.c @@ -52,8 +52,6 @@ acpi_gpiobus_convflags(ACPI_RESOURCE_GPIO *gpio_res) uint32_t flags = 0; /* Figure out pin flags */ -#ifdef NOT_YET - /* These are currently unused. */ if (gpio_res->ConnectionType == ACPI_RESOURCE_GPIO_TYPE_INT) { switch (gpio_res->Polarity) { case ACPI_ACTIVE_HIGH: @@ -69,10 +67,12 @@ acpi_gpiobus_convflags(ACPI_RESOURCE_GPIO *gpio_res) break; } +#ifdef NOT_YET + /* This is not currently implemented. */ if (gpio_res->Shareable == ACPI_SHARED) flags |= GPIO_INTR_SHAREABLE; - } #endif + } switch (gpio_res->IoRestriction) { case ACPI_IO_RESTRICT_INPUT: flags |= GPIO_PIN_INPUT;