Re: git: 9b8db66402e9 - main - netgraph: provide separate malloc type for nodes that are missing it

From: Gleb Smirnoff <glebius_at_freebsd.org>
Date: Tue, 04 Jun 2024 18:33:43 UTC
On Fri, May 31, 2024 at 06:03:16PM +0000, Brooks Davis wrote:
B> > Author:     Dmitry Lukhtionov <dmitryluhtionov@gmail.com>
B> > AuthorDate: 2024-05-31 16:19:54 +0000
B> > Commit:     Gleb Smirnoff <glebius@FreeBSD.org>
B> > CommitDate: 2024-05-31 16:19:54 +0000
B> > 
B> >     netgraph: provide separate malloc type for nodes that are missing it
B> >     
B> >     The kernel option NG_SEPARATE_MALLOC helps to debug memory leaks in
B> >     netgraph(4).  Several nodes were missing the support.
B> 
B> I realize this commit didn't create the option, but is there really
B> enough of a cost to having multiple malloc types to justify an option at
B> all?

This is just how it has been since early days of netgraph, and it makes
some missing nodes to honor the flag, thus I just accepted the
submission.

I have no objection if afedorov@ or anybody else takes a more thoughful
evaluation and changes that.

-- 
Gleb Smirnoff