From nobody Tue Jun 04 18:33:43 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Vtzkg3Xljz5MPWT; Tue, 04 Jun 2024 18:33:47 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Vtzkg2zt4z4Sd4; Tue, 4 Jun 2024 18:33:47 +0000 (UTC) (envelope-from glebius@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1717526027; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=SFH9K2YR3EZQxcTihcGRMwfqO2NM+MzPvOflALIjNCQ=; b=qGWYkaCsgKgdVS5DjXMIinnHuMxRuZHC01s5YxzPTgac1jqcX1brZQkNPOar8pAeDhdIZe oitnl29hhvVGSA2DEdw55nrkVKMO0p8dqxQqWtmgm9ZPybpou2U2/3uLZcZ+cV/p4EqT4/ InJhxtu71COxS6agu8pGAK8WOjZC9+e7fsq3Y/1KDnghOke6ViYZz7l80dQ4Q9r+yIYg9/ A7BzpADJHs+0hn9FKF45vbUWVIdtRCNAAhW9RSSikT2d2855OAc1tqDymcqJXtGyFczy78 i0PMgd1NpZ3BGZOYaTTovaPblX6tpLXL2PN5ymgp1QWDEpwc1O4CuInNbBud1g== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1717526027; a=rsa-sha256; cv=none; b=A/iUld2CzYscisXFJ3Jo2acZO0nl6GKsB1bPh9wizEL4K49oo3TSxdli0YGHE50r0lk/hw Le15s1ZFPdKQbOoRH4lpbEcF67TEDWmP1bbKq4jIZsOEg967F/0v6m9LZo5DKu6xpzqIhX 14VIfNX8MiC4EL445UIUqE+1KufuJwru1KaVyNcqOpVu7k51DNaSctOubJwZEpdsXlXyr7 oVFeI7r8SBt9aKNixqsIBVXTh3YdKXhlK4u3lq7xXnUrk21auucMqyQ+/qXN5aTMGxKVXH 54k6M9yOOfPNmcGXZVqaLEEIzMMrw+zvEpTczDRmpgUdipiPPKZa9KVT4IslDw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1717526027; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=SFH9K2YR3EZQxcTihcGRMwfqO2NM+MzPvOflALIjNCQ=; b=Bn1Fa1lnOB7VqKSA8U4EJalMkSbr96jybG+y3yWCxcfbb2rJh1Aftr4XuCJf2uZCwqcscF UbKMJvmsIYdn5AlaDZNR4hLsqia3VmbJn/AEgtFRbsH/hpU6cpV2smbHvYvUxQMmSw5H2m bfZ1huQ0LQW97vEOsDvyWPsgjIQZuC+GQWng4W+Zib8YplhU7ZWN7whfByZ1xHcc2BSKWB 59RfitvxmurCZFcgXbAIA5623srOb49MZajQUa3kVY06voD6w94nIdvZiuAF4AoBLutAlx fX4RYw+orEvhCoa6sx28j/wwnD0ZVysqhbukgU1YeD50eLpQe4/Eo5k6f3+yZg== Received: from cell.glebi.us (glebi.us [162.251.186.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: glebius) by smtp.freebsd.org (Postfix) with ESMTPSA id 4Vtzkf59bfzHkR; Tue, 4 Jun 2024 18:33:46 +0000 (UTC) (envelope-from glebius@freebsd.org) Date: Tue, 4 Jun 2024 11:33:43 -0700 From: Gleb Smirnoff To: Brooks Davis Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 9b8db66402e9 - main - netgraph: provide separate malloc type for nodes that are missing it Message-ID: References: <202405311620.44VGK2xX033356@gitrepo.freebsd.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, May 31, 2024 at 06:03:16PM +0000, Brooks Davis wrote: B> > Author: Dmitry Lukhtionov B> > AuthorDate: 2024-05-31 16:19:54 +0000 B> > Commit: Gleb Smirnoff B> > CommitDate: 2024-05-31 16:19:54 +0000 B> > B> > netgraph: provide separate malloc type for nodes that are missing it B> > B> > The kernel option NG_SEPARATE_MALLOC helps to debug memory leaks in B> > netgraph(4). Several nodes were missing the support. B> B> I realize this commit didn't create the option, but is there really B> enough of a cost to having multiple malloc types to justify an option at B> all? This is just how it has been since early days of netgraph, and it makes some missing nodes to honor the flag, thus I just accepted the submission. I have no objection if afedorov@ or anybody else takes a more thoughful evaluation and changes that. -- Gleb Smirnoff