Re: git: d2be7ed63aff - main - cred: proc_set_cred(), proc_unset_cred(): Update user's process count

In message <2968186.slGk94SIus@ravel>, Olivier Certner writes:
> --nextPart3019747.hHqAuc6tWs
> Content-Transfer-Encoding: 7Bit
> Content-Type: text/plain; charset="UTF-8"; protected-headers="v1"
> From: Olivier Certner <olce@freebsd.org>
> Date: Mon, 16 Dec 2024 16:44:37 +0100
> Message-ID: <2968186.slGk94SIus@ravel>
> In-Reply-To: <20241216152936.AC31A1AF@slippy.cwsent.com>
> MIME-Version: 1.0
>
> > I was just about to push this:
>
> Ah, didn't see your mail.  Just pushed a fix.
>
> >  proc_set_cred(struct proc *p, struct ucred *newcred)
> >  {
> > -	bool success = _proc_set_cred(p, newcred, false);
> > +#ifdef INVARIANTS
> > +	bool success =
> > +#endif
> > +	_proc_set_cred(p, newcred, false);
> >  
> >  	MPASS(success);
>
> Apparently, the idiom for such a situation is to tag the variable with `__dia
> gused`, but the change above would have worked the same in the end.

I totally forgot about that.

>
> Thanks for watching the build!

Some of my machines use DEBUG others not.

>
> (And I now have one more thing on my before-commit list, since I forgot GENER
> IC-NODEBUG).

I typically make tinderbox (or make universe) in one of the universe jails.


-- 
Cheers,
Cy Schubert <Cy.Schubert@cschubert.com>
FreeBSD UNIX:  <cy@FreeBSD.org>   Web:  https://FreeBSD.org
NTP:           <cy@nwtime.org>    Web:  https://nwtime.org

			e^(i*pi)+1=0