From nobody Mon Dec 16 15:49:23 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YBks54DWhz5hbVb; Mon, 16 Dec 2024 15:49:29 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from omta003.cacentral1.a.cloudfilter.net (omta001.cacentral1.a.cloudfilter.net [3.97.99.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YBks51zmLz4KD8; Mon, 16 Dec 2024 15:49:29 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Authentication-Results: mx1.freebsd.org; none Received: from shw-obgw-4001a.ext.cloudfilter.net ([10.228.9.142]) by cmsmtp with ESMTPS id NBWBti37aIx4rNDLZtGult; Mon, 16 Dec 2024 15:49:25 +0000 Received: from spqr.komquats.com ([70.66.136.217]) by cmsmtp with ESMTPSA id NDLXtrnVcGvSVNDLYtShY1; Mon, 16 Dec 2024 15:49:25 +0000 X-Auth-User: cschuber X-Authority-Analysis: v=2.4 cv=FpSm/Hrq c=1 sm=1 tr=0 ts=67604c05 a=h7br+8Ma+Xn9xscxy5znUg==:117 a=h7br+8Ma+Xn9xscxy5znUg==:17 a=kj9zAlcOel0A:10 a=RZcAm9yDv7YA:10 a=6I5d2MoRAAAA:8 a=EkcXrb_YAAAA:8 a=VxmjJ2MpAAAA:8 a=YxBL1-UpAAAA:8 a=VN7zgYw1dXOwZQa7yrgA:9 a=CjuIK1q_8ugA:10 a=LK5xJRSDVpKd5WXXoEvA:22 a=7gXAzLPJhVmCkEl4_tsf:22 a=Ia-lj3WSrqcvXOmTRaiG:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTP id 4579426E6; Mon, 16 Dec 2024 07:49:23 -0800 (PST) Received: by slippy.cwsent.com (Postfix, from userid 1000) id 1D64079; Mon, 16 Dec 2024 07:49:23 -0800 (PST) X-Mailer: exmh version 2.9.0 11/07/2018 with nmh-1.8+dev Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Olivier Certner cc: Cy Schubert , Baptiste Daroussin , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: d2be7ed63aff - main - cred: proc_set_cred(), proc_unset_cred(): Update user's process count In-reply-to: <2968186.slGk94SIus@ravel> References: <202412161445.4BGEjYvf052320@gitrepo.freebsd.org> <8184418.bYQgcRI8ro@ravel> <20241216152936.AC31A1AF@slippy.cwsent.com> <2968186.slGk94SIus@ravel> Comments: In-reply-to Olivier Certner message dated "Mon, 16 Dec 2024 16:44:37 +0100." List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Mon, 16 Dec 2024 07:49:23 -0800 Message-Id: <20241216154923.1D64079@slippy.cwsent.com> X-CMAE-Envelope: MS4xfLJvCMlTy/rBkbToVK008QXtnPlkA+IefiGt5oXfmPrJjd0lxVyk1XWb6X3iMK1k/tbtInyg5PLTZcyY+hck/nL2IqAUyvHaOBNtKgp44qmMDls1U+VR 5wqXNjsb/ucds1O538mq/HRCv1MGrVoCae+dqVt89M1fo6KHNJOFuyra/a4aL3dMj7CaUVIsc2LZHFtm4VwQ8NWhgb2q++ykyh4pcpwKjBK4oum0XJWSONLx djXToQmE/o9BY5J5BNNTDcQEqxvknPVprz1xtx+qO1AJE/v1HPCpMj7tm9RSDqaOJxG1TCJRE4n6PRoCW+Ys/utTUFUz/X7B0YZo9fpv0dHFHksAarm+MGXP BlTRH+ma X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:16509, ipnet:3.96.0.0/15, country:US] X-Rspamd-Queue-Id: 4YBks51zmLz4KD8 X-Spamd-Bar: ---- In message <2968186.slGk94SIus@ravel>, Olivier Certner writes: > --nextPart3019747.hHqAuc6tWs > Content-Transfer-Encoding: 7Bit > Content-Type: text/plain; charset="UTF-8"; protected-headers="v1" > From: Olivier Certner > Date: Mon, 16 Dec 2024 16:44:37 +0100 > Message-ID: <2968186.slGk94SIus@ravel> > In-Reply-To: <20241216152936.AC31A1AF@slippy.cwsent.com> > MIME-Version: 1.0 > > > I was just about to push this: > > Ah, didn't see your mail. Just pushed a fix. > > > proc_set_cred(struct proc *p, struct ucred *newcred) > > { > > - bool success = _proc_set_cred(p, newcred, false); > > +#ifdef INVARIANTS > > + bool success = > > +#endif > > + _proc_set_cred(p, newcred, false); > > > > MPASS(success); > > Apparently, the idiom for such a situation is to tag the variable with `__dia > gused`, but the change above would have worked the same in the end. I totally forgot about that. > > Thanks for watching the build! Some of my machines use DEBUG others not. > > (And I now have one more thing on my before-commit list, since I forgot GENER > IC-NODEBUG). I typically make tinderbox (or make universe) in one of the universe jails. -- Cheers, Cy Schubert FreeBSD UNIX: Web: https://FreeBSD.org NTP: Web: https://nwtime.org e^(i*pi)+1=0