Re: git: 87e140a5c6f8 - main - iwlwifi: avoid (hard) hang on loading module

On Mon, 9 Dec 2024, Jessica Clarke wrote:

> On 9 Dec 2024, at 14:47, Bjoern A. Zeeb <bz@FreeBSD.org> wrote:
>>
>> The branch main has been updated by bz:
>>
>> URL: https://cgit.FreeBSD.org/src/commit/?id=87e140a5c6f89eea7ea6320d1ae34566492abfc0
>> + if (bootverbose)
>> +       printf("%s: module '%s' not yet available; will be"
>> +   "initialized in a moment\n", __func__, op->name);
>
> Missing a space in the string.

Thanks; I'll add that.

> Also, why not just have request_module_nowait itself defer the load
> until it can be done, at which point it can notice that there’s nothing
> to do?

Because it's tricky and the (simple) request_module() in LinuxKPI
pre-dates me.  I think our users currently are a lot happier having
working WiFi (or a non-hanging kernel) than to wait some more time.
And frankly it's the only place in WiFi this is used and we do not need
it, so I'd rather focus on other user-facing problems.

/bz

-- 
Bjoern A. Zeeb                                                     r15:7