From nobody Tue Dec 10 01:55:15 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Y6hdM5MY7z5h5NH; Tue, 10 Dec 2024 01:55:19 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Y6hdM4QB3z4jvN; Tue, 10 Dec 2024 01:55:19 +0000 (UTC) (envelope-from bz@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1733795719; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9UutusI8e7usStpz2dgq5NrF4F4bmjN95T0mtzH6Jqg=; b=PBeFu60PBxuWk5N/h1TD9vzVk90PNt8pN6SVFbUas8Zo2ZEg16lDZcxEPiYe1dPwAwEcK0 TkjBtDW3Olv3sqwzzul0Wez3PdAkkxTP8hq9oWkUy/rJ7SBe/1+gBx4xSZJeTT4kvP9Qog OwIi/RkwNaGuSuWAzPd2tCfAv1JQcZuh65zaFNp2eDq54ehE8HMiggs99mH4VBLM4QBBlp TyAjnyJ6SauIzv20mF6Siz0iaVlQbbF0ijS0ws9pCsW8GB/NYhWmKlrhAW0ww3ugk0lzYG RhiMp75IJd1Ci+I4MQM+ct8ypG4iEiDcVWQsXAgkKHVyxQ10K0osXTEfdW8cTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1733795719; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9UutusI8e7usStpz2dgq5NrF4F4bmjN95T0mtzH6Jqg=; b=T5t1oCNAEm6RBIMvWn7fm+PoFwrNdn685v/gK7ubE+yP8QQ2UxEv5Gd5O9zg8HfjRcy8XP V+4fNrdXdMJj813PtRdpE07tccXFHVRiW5KkS2Oz9GMWne+mqUhrxYtcBVmMADwi50D02B zhkHkPYqL0f+XFqHnvzvHu307E9SDsA4uh/pB0L5XolhNjxK+MQzMM3nGJ7VwG73AxBVPt JPejPOdw2nIK97KKFNHRC8qThSiMlt8bDHqePKrV6wa1X6PPkhf4NzoXf9xc5YnWWsTz7R 1vsAy7vyDT3Q4sfgpYfQ3EJMmbhTQ96gPCPp6StCIaMsJcrrZAIh+6IKTM4Muw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1733795719; a=rsa-sha256; cv=none; b=g3jwneTUJ/vbm6Zw+KRG6+i+8bUDj9KiWBFoxHhiAm/F9//YoAbVGpH3KtkVlfQkWVDqH0 1NZbB5fhZZMgjHZ8GvBlgZf4ZfeLjOHyTWNifSTUYh0ZaAoCve7AOiWz12cY3dOnwqBf1i BvRfz5I/yud/xhXcBd+8ohQa9ZqYZeOzqBS9zxy26/VtWf+L0DkLLokYQbudYjswSMVp7l KVAyb6NsL0YjjJ/eaIH3HHmnwjwyHiO40xvRXZTDmU2aG3iBCvBzVntd6jZ+e095qd5/7H 7FXCR6JgQN7aJe6G8xq2QQeb/gae2N3QIRPaLgrqXGbYNE8ZFf11jBDTMCMsOQ== Received: from mx-01.divo.sbone.de (mx-01.divo.sbone.de [IPv6:2003:a:140a:2200:6:594:fffe:19]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature ECDSA (P-256) client-digest SHA256) (Client CN "mx-01.divo.sbone.de", Issuer "E6" (verified OK)) (Authenticated sender: bz/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4Y6hdM33zhz11XF; Tue, 10 Dec 2024 01:55:19 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from mail.sbone.de (mail.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:1025]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by mx-01.divo.sbone.de (Postfix) with ESMTPS id 5E4A4A64805; Tue, 10 Dec 2024 01:55:11 +0000 (UTC) Received: from content-filter.t4-02.sbone.de (content-filter.t4-02.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:2742]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPS id 9FFF72D029DC; Tue, 10 Dec 2024 01:55:17 +0000 (UTC) X-Virus-Scanned: amavisd-new at sbone.de Received: from mail.sbone.de ([IPv6:fde9:577b:c1a9:4902:0:7404:2:1025]) by content-filter.t4-02.sbone.de (content-filter.t4-02.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:2742]) (amavisd-new, port 10024) with ESMTP id 08PL9OtZPdZf; Tue, 10 Dec 2024 01:55:16 +0000 (UTC) Received: from strong-iwl0.sbone.de (strong-iwl0.sbone.de [IPv6:fde9:577b:c1a9:4902:b66b:fcff:fef3:e3d2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPSA id 65A712D029D8; Tue, 10 Dec 2024 01:55:16 +0000 (UTC) Date: Tue, 10 Dec 2024 01:55:15 +0000 (UTC) From: "Bjoern A. Zeeb" To: Jessica Clarke cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Subject: Re: git: 87e140a5c6f8 - main - iwlwifi: avoid (hard) hang on loading module In-Reply-To: <6F9C2C43-A3DD-4CF5-AC27-899FE139E9A6@freebsd.org> Message-ID: <0883q825-802q-2n9q-3s4o-3nq13qpqno71@SerrOFQ.bet> References: <202412091447.4B9ElFBH050286@gitrepo.freebsd.org> <6F9C2C43-A3DD-4CF5-AC27-899FE139E9A6@freebsd.org> X-OpenPGP-Key-Id: 0x14003F198FEFA3E77207EE8D2B58B8F83CCF1842 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="1098556516-515570521-1733795716=:2228" This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --1098556516-515570521-1733795716=:2228 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8BIT On Mon, 9 Dec 2024, Jessica Clarke wrote: > On 9 Dec 2024, at 14:47, Bjoern A. Zeeb wrote: >> >> The branch main has been updated by bz: >> >> URL: https://cgit.FreeBSD.org/src/commit/?id=87e140a5c6f89eea7ea6320d1ae34566492abfc0 >> + if (bootverbose) >> + printf("%s: module '%s' not yet available; will be" >> + "initialized in a moment\n", __func__, op->name); > > Missing a space in the string. Thanks; I'll add that. > Also, why not just have request_module_nowait itself defer the load > until it can be done, at which point it can notice that there’s nothing > to do? Because it's tricky and the (simple) request_module() in LinuxKPI pre-dates me. I think our users currently are a lot happier having working WiFi (or a non-hanging kernel) than to wait some more time. And frankly it's the only place in WiFi this is used and we do not need it, so I'd rather focus on other user-facing problems. /bz -- Bjoern A. Zeeb r15:7 --1098556516-515570521-1733795716=:2228--