Re: git: f6efccaa35fe - main - IfAPI: Remove temporary inclusion of if_private.h

On Wed, 4 Dec 2024 14:48:40 -0500
John Baldwin <jhb@FreeBSD.org> wrote:

> On 11/13/24 14:29, Justin Hibbits wrote:
> > The branch main has been updated by jhibbits:
> > 
> > URL: https://cgit.FreeBSD.org/src/commit/?id=f6efccaa35fe07f5659dd5d84769f56453f12169
> > 
> > commit f6efccaa35fe07f5659dd5d84769f56453f12169
> > Author:     Justin Hibbits <jhibbits@FreeBSD.org>
> > AuthorDate: 2024-11-08 19:42:19 +0000
> > Commit:     Justin Hibbits <jhibbits@FreeBSD.org>
> > CommitDate: 2024-11-13 19:31:20 +0000
> > 
> >      IfAPI: Remove temporary inclusion of if_private.h
> >      
> >      Summary:
> >      The kernel is now fully migrated to the IfAPI, so remove the
> > temporary inclusion of the private structure definition.
> >      
> >      Reviewed By:    #network, melifaro
> >      Differential Revision:  https://reviews.freebsd.org/D39621  
> 
> This has broken many kmods in ports.  Are you planning to fix those?
> So far I count
> 
> emulators/parallels-tools
> net/aoe
> net/aquantia-atlantic-kmod
> net/intel-iavf-kmod
> net/intel-ice-kmod
> net/intel-igb-kmod
> net/intel-ix-kmod
> net/intel-ixl-kmod
> net/ndproxy
> net/vether-kmod
> 

Hi John,

I requested an exp-run last year for this very change
(https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=272030), and gave a heads-up
to all the maintainers last July (2023).  Some of those ports found
in the exp-run have since been fixed, though as you pointed out above,
not all.  PRs have been filed for most of them.

- Justin