From nobody Wed Dec 04 22:49:59 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Y3Xlr5gZtz5gKYx; Wed, 04 Dec 2024 22:50:00 +0000 (UTC) (envelope-from jhibbits@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Y3Xlr4q63z4TJ6; Wed, 4 Dec 2024 22:50:00 +0000 (UTC) (envelope-from jhibbits@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1733352600; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JFIoeS0kBnqUAbIEJjCI0J/f3rThklAp7N8OijGEJfE=; b=aG+9Aa/ccA4bxl0TjRhtZcZt+y6Tj0iAh/iNijLYnkNEyMRJQ7nTJ2mr3D8kk+dj+Dlqp7 gSzC2eh+XWRS1CrOjJFqzYDr8xaIEOfe+A3GT3ZS7SsF02WPbAwUoMmb3N2cl1QDO8OSKd vqjYji5Lhk5o/khHZgzwDF3Yj7jH5QfGilFu1outAGOvrkmvrLLjMHF+5cu1uJSm/QDwwe BH0iFxjlBahGx3jp+d/NnKUSPwI9vav1YU5tA0NLZ/gxw1p0P9+CxiTPDkVwhekF6U4+EC p5h9h8HFNcFjpZ5wpuzN5Q9isXOUNGjVPTRf6aBCO25Cpx2srYKTUdqG8eh2Iw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1733352600; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JFIoeS0kBnqUAbIEJjCI0J/f3rThklAp7N8OijGEJfE=; b=nLn5m0WPf/bGaiGRG91NPKy6N+x+a4QFtaTvkYm1z5j/9FyrjZZYPqNH8j+1Xga6i3tATH 4NX5cmFeaNYMNbZpVS34hYvmI/By5VgVyLhix1AqwRMSzaXHqOLURSyfVLMRAc5tBW/96c 7N8dqjctjYGcHOyHOpt+foE2XEzLVuyTYjijCKGBFLSNVIhUFKBr5hjC10Xkfo53G9dewC ccAlRpQ7pU51ovX/fnt85QxyNs8DLXSnIBDR0j+LHV6zBhrSbnlXrTc/12Hi9cn9+FH3+r N10flCJJwc2R2J//5dQe2WafAXPF9LzAyd/ne00ODCbwWMR3Iw6wyfNhEDg1bA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1733352600; a=rsa-sha256; cv=none; b=iQOfzC6CRQnYunALJROB0oVkoqmzcW/qnRKoP/Wn0sukA1e9Zlm4fgGOPXh7NRtLWgwsyF VzWD9DbuMl+lVArNK5oYm41tv7HFPAb93SA9lUHjBwYEqjqc1AQFmorntCy/qlV/dlQ8YK XqsT2IDEe47Y2myu/EdJGGAKB4aKnozL396cs+hQK0oOlzqV5r0JMpRlPdbKvo+MRBf7tm JFMI39UQ3p0e733y129+duzcnJpIIBWl6TNQfoNAhoJv5TJMLbunWGDLr6r7BEZoHXaA4K D5f7trcUqu00SRmhJU2TwMwI1VOkhG94UJu9lMOPbFVSI+hhXNXNqPNWyghIJw== Received: from ralga.knownspace (unknown [IPv6:2600:2b00:a720:d301:9f03:382a:d672:81f0]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhibbits) by smtp.freebsd.org (Postfix) with ESMTPSA id 4Y3Xlr31Gkz1KqR; Wed, 4 Dec 2024 22:50:00 +0000 (UTC) (envelope-from jhibbits@FreeBSD.org) Date: Wed, 4 Dec 2024 17:49:59 -0500 From: Justin Hibbits To: John Baldwin Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: f6efccaa35fe - main - IfAPI: Remove temporary inclusion of if_private.h Message-ID: <20241204174959.34814f55@ralga.knownspace> In-Reply-To: <343e4be1-6f01-4080-981c-32bf309bacb2@FreeBSD.org> References: <202411131929.4ADJTcCe033652@gitrepo.freebsd.org> <343e4be1-6f01-4080-981c-32bf309bacb2@FreeBSD.org> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.43; powerpc64le-unknown-linux-gnu) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 4 Dec 2024 14:48:40 -0500 John Baldwin wrote: > On 11/13/24 14:29, Justin Hibbits wrote: > > The branch main has been updated by jhibbits: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=f6efccaa35fe07f5659dd5d84769f56453f12169 > > > > commit f6efccaa35fe07f5659dd5d84769f56453f12169 > > Author: Justin Hibbits > > AuthorDate: 2024-11-08 19:42:19 +0000 > > Commit: Justin Hibbits > > CommitDate: 2024-11-13 19:31:20 +0000 > > > > IfAPI: Remove temporary inclusion of if_private.h > > > > Summary: > > The kernel is now fully migrated to the IfAPI, so remove the > > temporary inclusion of the private structure definition. > > > > Reviewed By: #network, melifaro > > Differential Revision: https://reviews.freebsd.org/D39621 > > This has broken many kmods in ports. Are you planning to fix those? > So far I count > > emulators/parallels-tools > net/aoe > net/aquantia-atlantic-kmod > net/intel-iavf-kmod > net/intel-ice-kmod > net/intel-igb-kmod > net/intel-ix-kmod > net/intel-ixl-kmod > net/ndproxy > net/vether-kmod > Hi John, I requested an exp-run last year for this very change (https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=272030), and gave a heads-up to all the maintainers last July (2023). Some of those ports found in the exp-run have since been fixed, though as you pointed out above, not all. PRs have been filed for most of them. - Justin