Re: git: 15e7fa83ef3c - main - arm64: Hyper-V: Add vPCI and Mellanox driver modules into build

On 14 Mar 2023, at 03:57, Jessica Clarke <jrtc27@FreeBSD.org> wrote:
> 
> On 13 Mar 2023, at 03:00, Wei Hu <whu@FreeBSD.org> wrote:
>> 
>> The branch main has been updated by whu:
>> 
>> URL: https://cgit.FreeBSD.org/src/commit/?id=15e7fa83ef3cd909e1d1b3b2cada8d9073f2e22e
>> 
>> commit 15e7fa83ef3cd909e1d1b3b2cada8d9073f2e22e
>> Author:     Wei Hu <whu@FreeBSD.org>
>> AuthorDate: 2023-03-13 02:55:04 +0000
>> Commit:     Wei Hu <whu@FreeBSD.org>
>> CommitDate: 2023-03-13 02:55:04 +0000
>> 
>>   arm64: Hyper-V: Add vPCI and Mellanox driver modules into build
> 
> What does Mellanox have to do with Hyper-V? I doubt it’s being emulated.

I guess because Azure Accelerated Networking has Mellanox hardware. In
which case it doesn’t belong in std.hyperv, it belongs in std.azure, as
std.hyperv is for things needed for Hyper-V, not platforms that happen
to use Hyper-V.

Jess

>>   These changes in conf and std.hyperv files got missed in previous commit.
>>   Reviewed by:    whu
>>   Tested by:      whu
>>   Obtained from:  Souradeep Chakrabarti <schakrabarti@microsoft.com>
>>   Sponsored by:   Microsoft
>>   Differential Revision:  https://reviews.freebsd.org/D38529
>> ---
>> sys/arm64/conf/std.hyperv | 12 +++++++++++-
>> sys/conf/files.arm64      |  1 +
>> 2 files changed, 12 insertions(+), 1 deletion(-)
>> 
>> diff --git a/sys/arm64/conf/std.hyperv b/sys/arm64/conf/std.hyperv
>> index f87082f15c96..b742c75da131 100644
>> --- a/sys/arm64/conf/std.hyperv
>> +++ b/sys/arm64/conf/std.hyperv
>> @@ -3,4 +3,14 @@
>> #
>> 
>> #hyper-v support
>> -device      hyperv
>> +device		hyperv
>> +
>> +options 	COMPAT_LINUXKPI
>> +device		xz
>> +
>> +device		mlx5
>> +device		mlxfw
>> +device		mlx5en
>> +options 	RATELIMIT
>> +options 	KERN_TLS
>> +device		firmware
>> diff --git a/sys/conf/files.arm64 b/sys/conf/files.arm64
>> index 684cb8cb23ba..22dd267b2b42 100644
>> --- a/sys/conf/files.arm64
>> +++ b/sys/conf/files.arm64
>> @@ -253,6 +253,7 @@ dev/hyperv/utilities/hv_kvp.c			optional hyperv acpi
>> dev/hyperv/netvsc/hn_nvs.c			optional hyperv acpi
>> dev/hyperv/netvsc/hn_rndis.c			optional hyperv acpi
>> dev/hyperv/netvsc/if_hn.c			optional hyperv acpi
>> +dev/hyperv/pcib/vmbus_pcib.c			optional hyperv pci acpi
>> 
>> dev/ice/if_ice_iflib.c				optional ice pci \
>> 	compile-with "${NORMAL_C} -I$S/dev/ice"
>