From nobody Tue Mar 14 04:04:26 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PbKfQ38mVz3xdRF for ; Tue, 14 Mar 2023 04:04:30 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PbKfP3qwwz44hV for ; Tue, 14 Mar 2023 04:04:29 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Authentication-Results: mx1.freebsd.org; dkim=none; spf=pass (mx1.freebsd.org: domain of jrtc27@jrtc27.com designates 209.85.128.53 as permitted sender) smtp.mailfrom=jrtc27@jrtc27.com; dmarc=none Received: by mail-wm1-f53.google.com with SMTP id r19-20020a05600c459300b003eb3e2a5e7bso9215257wmo.0 for ; Mon, 13 Mar 2023 21:04:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678766668; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=98+sWG7asc9QY5NV6/1S26MCjVF4ePHoilh6QHM7C7g=; b=WaekpAU4Dw7p69AmIu7XMGehy1mcqfQScRJgq9pN3nFmPcfdRJT0mJKQMs+ItZNKq2 FtUPOG2I1Wxtsu2vNvZjzEnmRTQAvm5JpTLtXY1mEL1tiN0WU4UyfShWtGwXA8JkRwDI XCRtcVmVkWXZoaHWgsMr+DySTNrMr2EbY7t6soHHGjGjh3PsvQOTBlD/mgrdxECPi/0I JKfnoH6qq8FtXCkRr8jaNkK+pHm+T34/hyOsaZw2euh+Sn3joDhmq77QAb4PVZItNTzf PYOlmcmR7nh9SSecqh62Svs3w/oZrOAVRkG8SsIXt7MgCvjE/kgh8YzrQztnQ8JXpbJZ rPPg== X-Gm-Message-State: AO0yUKU++gQGd7p/ktT89GUNeXZKLGhO+BeIEPsK0GvdFTqi62Nw5NQ1 XaFi00u/AM86KfRwITCgrQ0J1g== X-Google-Smtp-Source: AK7set/3tQghowAHZlsv6wU0WPqdPwytsAE2FAjWy3AYVK7jFVQVNEHymRUDiYmXiyP4FQs0IIr7oA== X-Received: by 2002:a05:600c:4506:b0:3ed:253c:621b with SMTP id t6-20020a05600c450600b003ed253c621bmr5162587wmo.21.1678766667904; Mon, 13 Mar 2023 21:04:27 -0700 (PDT) Received: from smtpclient.apple (global-5-144.n-2.net.cam.ac.uk. [131.111.5.144]) by smtp.gmail.com with ESMTPSA id a16-20020a5d4570000000b002c5539171d1sm985615wrc.41.2023.03.13.21.04.26 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 13 Mar 2023 21:04:27 -0700 (PDT) Content-Type: text/plain; charset=utf-8 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Subject: Re: git: 15e7fa83ef3c - main - arm64: Hyper-V: Add vPCI and Mellanox driver modules into build From: Jessica Clarke In-Reply-To: Date: Tue, 14 Mar 2023 04:04:26 +0000 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: <4F72E2FD-6E84-40F1-981D-A18C8DE22FDD@freebsd.org> References: <202303130300.32D30Q0K068420@gitrepo.freebsd.org> To: Wei Hu X-Mailer: Apple Mail (2.3696.120.41.1.1) X-Spamd-Result: default: False [-2.36 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-0.999]; NEURAL_HAM_SHORT(-0.86)[-0.858]; MV_CASE(0.50)[]; FORGED_SENDER(0.30)[jrtc27@freebsd.org,jrtc27@jrtc27.com]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; MIME_GOOD(-0.10)[text/plain]; RCPT_COUNT_THREE(0.00)[4]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-src-main@freebsd.org]; TO_DN_EQ_ADDR_SOME(0.00)[]; DMARC_NA(0.00)[freebsd.org]; FROM_HAS_DN(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[209.85.128.53:from]; TO_MATCH_ENVRCPT_SOME(0.00)[]; FREEFALL_USER(0.00)[jrtc27]; MIME_TRACE(0.00)[0:+]; MLMMJ_DEST(0.00)[dev-commits-src-main@freebsd.org]; RCVD_COUNT_THREE(0.00)[3]; TO_DN_SOME(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; R_DKIM_NA(0.00)[]; FROM_NEQ_ENVFROM(0.00)[jrtc27@freebsd.org,jrtc27@jrtc27.com]; MID_RHS_MATCH_FROM(0.00)[]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.128.53:from] X-Rspamd-Queue-Id: 4PbKfP3qwwz44hV X-Spamd-Bar: -- X-ThisMailContainsUnwantedMimeParts: N On 14 Mar 2023, at 03:57, Jessica Clarke wrote: >=20 > On 13 Mar 2023, at 03:00, Wei Hu wrote: >>=20 >> The branch main has been updated by whu: >>=20 >> URL: = https://cgit.FreeBSD.org/src/commit/?id=3D15e7fa83ef3cd909e1d1b3b2cada8d90= 73f2e22e >>=20 >> commit 15e7fa83ef3cd909e1d1b3b2cada8d9073f2e22e >> Author: Wei Hu >> AuthorDate: 2023-03-13 02:55:04 +0000 >> Commit: Wei Hu >> CommitDate: 2023-03-13 02:55:04 +0000 >>=20 >> arm64: Hyper-V: Add vPCI and Mellanox driver modules into build >=20 > What does Mellanox have to do with Hyper-V? I doubt it=E2=80=99s being = emulated. I guess because Azure Accelerated Networking has Mellanox hardware. In which case it doesn=E2=80=99t belong in std.hyperv, it belongs in = std.azure, as std.hyperv is for things needed for Hyper-V, not platforms that happen to use Hyper-V. Jess >> These changes in conf and std.hyperv files got missed in previous = commit. >> Reviewed by: whu >> Tested by: whu >> Obtained from: Souradeep Chakrabarti >> Sponsored by: Microsoft >> Differential Revision: https://reviews.freebsd.org/D38529 >> --- >> sys/arm64/conf/std.hyperv | 12 +++++++++++- >> sys/conf/files.arm64 | 1 + >> 2 files changed, 12 insertions(+), 1 deletion(-) >>=20 >> diff --git a/sys/arm64/conf/std.hyperv b/sys/arm64/conf/std.hyperv >> index f87082f15c96..b742c75da131 100644 >> --- a/sys/arm64/conf/std.hyperv >> +++ b/sys/arm64/conf/std.hyperv >> @@ -3,4 +3,14 @@ >> # >>=20 >> #hyper-v support >> -device hyperv >> +device hyperv >> + >> +options COMPAT_LINUXKPI >> +device xz >> + >> +device mlx5 >> +device mlxfw >> +device mlx5en >> +options RATELIMIT >> +options KERN_TLS >> +device firmware >> diff --git a/sys/conf/files.arm64 b/sys/conf/files.arm64 >> index 684cb8cb23ba..22dd267b2b42 100644 >> --- a/sys/conf/files.arm64 >> +++ b/sys/conf/files.arm64 >> @@ -253,6 +253,7 @@ dev/hyperv/utilities/hv_kvp.c = optional hyperv acpi >> dev/hyperv/netvsc/hn_nvs.c optional hyperv acpi >> dev/hyperv/netvsc/hn_rndis.c optional hyperv acpi >> dev/hyperv/netvsc/if_hn.c optional hyperv acpi >> +dev/hyperv/pcib/vmbus_pcib.c optional hyperv = pci acpi >>=20 >> dev/ice/if_ice_iflib.c optional ice pci = \ >> compile-with "${NORMAL_C} -I$S/dev/ice" >=20