Re: git: cb96a0ef0040 - main - cp: Minor code cleanup.

From: Kyle Evans <kevans_at_freebsd.org>
Date: Fri, 03 Feb 2023 16:41:36 UTC 
On Fri, Feb 3, 2023 at 10:30 AM Kyle Evans <kevans@freebsd.org> wrote:
>
> On Fri, Feb 3, 2023 at 10:16 AM Dag-Erling Smørgrav <des@freebsd.org> wrote:
> >
> > Kyle Evans <kevans@freebsd.org> writes:
> > > fts_read() doesn't always set errno to 0; notably, there's a number of
> > > FCHDIR() paths that don't set errno (and the change that added it
> > > mentions that scenario exactly) and will return NULL because of an
> > > error.
> >
> > The man page says it does, and as far as I can tell from the code it
> > does.  Can you please provide a test case?
> >
>
> Ahh, I missed that FTS_NOCHDIR is set here.

(among other things I missed, but it's irrelevant because i withdraw
previous commentary anyways due to overlooking many many details)