From nobody Fri Feb 03 16:41:36 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4P7hJ853K2z3kW3D; Fri, 3 Feb 2023 16:41:44 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4P7hJ84c1hz3svB; Fri, 3 Feb 2023 16:41:44 +0000 (UTC) (envelope-from kevans@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1675442504; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BmmHuh3Es7Sgbad0tCW9R8jOt+6RRGQNKhCJ0YfcxWE=; b=TUTE7wFBAhTcyXdpRCKZh366Vl7f22AzbXuAP34qJbOlMgK/ng5hwUZjlkkPOPLwK05qWO ffU5gOV2mwzU0Bk7sDyuVS0/OCM0Ku+A+WvicA7RyaWQ8NU6px3bY+Os11AVMwm47C2CmK 1N2yayetLHqlbczTxUG6C3BAn7G6UXzMrONHIyxdn89WDE9j4Mt0lTJ2oRK/jcpVgvSu7t /jOX2bOqL4NXdo0bdD6aar1UiDtWGGmu60wdTGuS+nGvZDvAMf8f5UaWfdy4kZqjJOJoIY BFdIfVweuHpso2Oj9N1wTd3vFq84LUL8KR09IbP//c7Ftou1kte5I11C18tJkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1675442504; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BmmHuh3Es7Sgbad0tCW9R8jOt+6RRGQNKhCJ0YfcxWE=; b=XAg5uwHFndM9p1mCnB6pu2lyHicPAo2MxBhAl4UAqnIk/1zVp4xdqg3lvlyMsJ6rLjsyG/ b+aNxjg6m40Pk9nzQ+Wz4HbtKUlqwdZWv/g9JsyQKKvK4r6TxGjZGTOyHz0/LujY9rws2z qRNsyf1FrNOxdUq90sauZ5EWPIN905dGC71T+1ZkZDQTEPZxjU+ZCvHAmcQVbu2CR16VRN 49Nm35ot7wX08mEGxkQIIgZEVoaDLumbMmyEhy3znd1k4N3PgoC4RaHYUcd3PH0Iubu86N YjLLHo1hJrWxLnCEYPHmpoxRpEd41MoMXDDQlUQ/6YxggNi35AfR8ZdZYFCpQg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1675442504; a=rsa-sha256; cv=none; b=k4SYAnp8VOednJ4HMXQdSyP80avf4Lh+z8jeN/0EXeXCcqCa3cVLxReCfigtHsUIBofcge pFP7nrkQtdgFV8FUny0vOykSz4CktyQhDBZqkqB1GpEYW38+0xGzG7iFoedyMkM9pMfLny Gzhi4oIVe94TKu43AYNuunwDnzA7FMTiD99GZWgGONCzTrXU6PiD7Qg33IllrSgFLEI1fE W3ZloIbt18a0XXlU4R/dTyEBU2oue6Mpdgsrc+C8Mgfk7ize6JyUEAVR1atc4tphQFWhfC JiVuMIgQSQlspZXvkRUemYA2lWOwPv8S7h2jKulsT9wIdCDxhLG82BeTbVZj7g== Received: from mail-qt1-f179.google.com (mail-qt1-f179.google.com [209.85.160.179]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) (Authenticated sender: kevans) by smtp.freebsd.org (Postfix) with ESMTPSA id 4P7hJ83Xmyz11hH; Fri, 3 Feb 2023 16:41:44 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: by mail-qt1-f179.google.com with SMTP id bb40so6103541qtb.2; Fri, 03 Feb 2023 08:41:44 -0800 (PST) X-Gm-Message-State: AO0yUKXFnpzsjZpyi6rDSFim34rIKnSoPS3QOrdqzDrKi9KR/4WK/xqM PwdBv66anhV2ewaKg4ZSy6QK5a6IjZqz8sO5xP0= X-Google-Smtp-Source: AK7set++4ipCqqCMk3owMjqvjNH2ax5lvpgiVawAlPGTR/EylzjdGnDCOwiTjugRRt2+FDHzlTEPELlvSUUhg41Px80= X-Received: by 2002:a05:622a:50a:b0:3b8:6bd1:950f with SMTP id l10-20020a05622a050a00b003b86bd1950fmr1173942qtx.128.1675442503944; Fri, 03 Feb 2023 08:41:43 -0800 (PST) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 References: <202302031558.313Fw2sJ051540@gndrsh.dnsmgr.net> <86lele3f6c.fsf@ltc.des.no> <86edr63ert.fsf@ltc.des.no> In-Reply-To: From: Kyle Evans Date: Fri, 3 Feb 2023 10:41:36 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: cb96a0ef0040 - main - cp: Minor code cleanup. To: Kyle Evans Cc: =?UTF-8?Q?Dag=2DErling_Sm=C3=B8rgrav?= , "Rodney W. Grimes" , rgrimes@freebsd.org, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-ThisMailContainsUnwantedMimeParts: N On Fri, Feb 3, 2023 at 10:30 AM Kyle Evans wrote: > > On Fri, Feb 3, 2023 at 10:16 AM Dag-Erling Sm=C3=B8rgrav wrote: > > > > Kyle Evans writes: > > > fts_read() doesn't always set errno to 0; notably, there's a number o= f > > > FCHDIR() paths that don't set errno (and the change that added it > > > mentions that scenario exactly) and will return NULL because of an > > > error. > > > > The man page says it does, and as far as I can tell from the code it > > does. Can you please provide a test case? > > > > Ahh, I missed that FTS_NOCHDIR is set here. (among other things I missed, but it's irrelevant because i withdraw previous commentary anyways due to overlooking many many details)