Re: git: c3fbd9c6212c - main - Revert "stand: Remove double words in source code comments"
Date: Tue, 18 Apr 2023 13:30:09 UTC
On 2023-04-18 at 02:09 EDT, Gordon Bergling <gbe@FreeBSD.org> wrote: >The branch main has been updated by gbe: > >URL: https://cgit.FreeBSD.org/src/commit/?id=c3fbd9c6212cad2634f5958ffec0370166ec7204 > >commit c3fbd9c6212cad2634f5958ffec0370166ec7204 >Author: Gordon Bergling <gbe@FreeBSD.org> >AuthorDate: 2023-04-18 06:08:35 +0000 >Commit: Gordon Bergling <gbe@FreeBSD.org> >CommitDate: 2023-04-18 06:08:35 +0000 > > Revert "stand: Remove double words in source code comments" > > The sentence, "The base address that we the boot0 code to to run it." > is correct. > > Reported by: jrtc27 > > This reverts commit b12ccd0bb1b37f32e972bb3e945e4025fe409e2f. >--- > stand/i386/boot0/Makefile | 2 +- > stand/libsa/zfs/zfsimpl.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > >diff --git a/stand/i386/boot0/Makefile b/stand/i386/boot0/Makefile >index dad078fd6f71..1453f17751b9 100644 >--- a/stand/i386/boot0/Makefile >+++ b/stand/i386/boot0/Makefile >@@ -36,7 +36,7 @@ BOOT_BOOT0_FLAGS?= 0x8f > # 0xb6 (182d) corresponds to 10 seconds. > BOOT_BOOT0_TICKS?= 0xb6 > >-# The base address that we the boot0 code to run it. Don't change this >+# The base address that we the boot0 code to to run it. Don't change this I really think this comment needs a verb (load), as observed by jrtc27@. Even better (?), as danfe@ suggested, it should possibly be rephrased as: "The base address where we load the boot0 code to run it. Don't change this." or something along those lines. Thanks, Matteo