From nobody Tue Apr 18 13:30:09 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Q14Y01yd0z456nK for ; Tue, 18 Apr 2023 13:30:12 +0000 (UTC) (envelope-from matteo@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Q14Xz1cqsz43Yw for ; Tue, 18 Apr 2023 13:30:11 +0000 (UTC) (envelope-from matteo@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1681824611; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9d6IclCS2Wcg8GkbtUlZmScy6WvvGFjokiXkO476OQo=; b=FSYkLmsEOQsUCrq+mTJGci+Lxnd5XozltGaL2eId/7x1KyPzMBz8R96I+AOS7Lhob1AOzb s0t0V8BJont9mr4oFZZ9XlwE/Svv+CCPpdEnjBvYC9N7JLsxFW7ja/4tscntM/otmZQ2RH iLQs68PwoGnLCZUrMEyE22SB/JDG0qmmxG0x3cuz/CviaFhXNiuQwoAhgRP4tCfNEP/SZ8 5R2/VjNtN/8mj2w77JLPkB80DKaFpH9S24kcncWmaPJGx3qynZn6XTSaWluFzi0t7Z3JB0 0xkJ/tRVyUhL9+biFojz6pts17o4zdYqdcvtN4QpnRJwKF/sK7SeErGxCPVIzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1681824611; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9d6IclCS2Wcg8GkbtUlZmScy6WvvGFjokiXkO476OQo=; b=rc2MJMBy/YAbASxDpL6Vv1APRbi75jNbyEoIL1se5M0BNAfUQdS/sdiLs+40Ka28IkfE9n 1GKDmqDSpL4Iw6alr/0L/ZszEbLciZv1TfUYIZzMpUwmdsShxMdYNpWEo0wPeFrvrCiDRj cLpE2yMwDO0q6//Y0YNNoSl30DNpW/tfs1FA3QIJxxe6uYUoWHqtzLgjxqUdaSYl7uD9uy ZQcx2emM2924RRr3fUOA19fbFHA2mDUDCk2SOVxNcfPVe0D32XKVvduzqObyMyZq4ddV7I f6QEcmNsc3Df5n06yUusl+eKyVnM9C2Cp6dS+2N+ewa1R0XxDSEt1Csj+CeQvA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1681824611; a=rsa-sha256; cv=none; b=tcf0X1qw2SvLZL09qNuFzJaGrMMT8igZxbSd/96RTUHdTvYkX5a93dIVqzi35R91Pei5Fe EsJ0nB9uX1FKYk4uFGdDl1p9eNnKDkYCmNqT2eA2svZZUZTPU2inxSVEytfjgoLbTniGNK ZDOi5Ba2WnnBQaKq4xDRozc6DQAVFbgFMG4p8AoJdxpgWxJwN14L1oKOmh2Apq8l4M9xhe htLwtp1U4FB61QxzHMnOXybIPeNUpCkVYk5GDDoM0C1m6FrEWa3MAHClOKx4mGdM7sBtki kBEz7SBSCmr/1lwowYI0RWNZiv5Eazo5w9CyOorwiMcZFQJFF1O+dafPCrOYOA== Received: from ubertino.local (unknown [IPv6:2601:19b:4400:2d2::1055]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: matteo/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4Q14Xy6ljRz14Jw for ; Tue, 18 Apr 2023 13:30:10 +0000 (UTC) (envelope-from matteo@freebsd.org) Date: Tue, 18 Apr 2023 09:30:09 -0400 From: Matteo Riondato To: dev-commits-src-main@freebsd.org Subject: Re: git: c3fbd9c6212c - main - Revert "stand: Remove double words in source code comments" Message-ID: <20230418133009.iiaz6l3fsjppybqc@ubertino.local> X-PGP-Key: http://rionda.to/files/matteogpg.asc References: <202304180609.33I69iRq089390@gitrepo.freebsd.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="n2wfaq6c23aiuwsc" Content-Disposition: inline In-Reply-To: <202304180609.33I69iRq089390@gitrepo.freebsd.org> X-ThisMailContainsUnwantedMimeParts: N --n2wfaq6c23aiuwsc Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2023-04-18 at 02:09 EDT, Gordon Bergling wrote: >The branch main has been updated by gbe: > >URL: https://cgit.FreeBSD.org/src/commit/?id=3Dc3fbd9c6212cad2634f5958ffec= 0370166ec7204 > >commit c3fbd9c6212cad2634f5958ffec0370166ec7204 >Author: Gordon Bergling >AuthorDate: 2023-04-18 06:08:35 +0000 >Commit: Gordon Bergling >CommitDate: 2023-04-18 06:08:35 +0000 > > Revert "stand: Remove double words in source code comments" > > The sentence, "The base address that we the boot0 code to to run it." > is correct. > > Reported by: jrtc27 > > This reverts commit b12ccd0bb1b37f32e972bb3e945e4025fe409e2f. >--- > stand/i386/boot0/Makefile | 2 +- > stand/libsa/zfs/zfsimpl.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > >diff --git a/stand/i386/boot0/Makefile b/stand/i386/boot0/Makefile >index dad078fd6f71..1453f17751b9 100644 >--- a/stand/i386/boot0/Makefile >+++ b/stand/i386/boot0/Makefile >@@ -36,7 +36,7 @@ BOOT_BOOT0_FLAGS?=3D 0x8f > # 0xb6 (182d) corresponds to 10 seconds. > BOOT_BOOT0_TICKS?=3D 0xb6 > >-# The base address that we the boot0 code to run it. Don't change this >+# The base address that we the boot0 code to to run it. Don't change this I really think this comment needs a verb (load), as observed by jrtc27@. Even better (?), as danfe@ suggested, it should possibly be rephrased=20 as: "The base address where we load the boot0 code to run it. Don't change=20 this." or something along those lines. Thanks, Matteo --n2wfaq6c23aiuwsc Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJHBAABCgAxFiEEa9uKZL0hP4E8Nl5vGwL9SVQlVQEFAmQ+m1wTGGhrcHM6Ly9w Z3AubWl0LmVkdQAKCRAbAv1JVCVVAdzGEADQpIRMwJxFlrj0D/phYBkB8ebr4BmL ugFtMpZ1ShXHc1lr0HSm8h38/V+FeYx9NjAGjpcWPOd1rNAtCt8w2GADFYTZ+wfI vw8E3PmRDBkWdvBhYXo+/0McjDGxzSFJCVMP5tZ2mjrEFeOluku0iiFndJ7PPiBV pvalVSarEKMhA5AAnzvJiE8bxpI8MhuSmzEkL+8kZks4oKsz5BUR4MTTSUAcGeCY oRtDEnfQBw53tq7TJmaqbRq0yb95PHHFiUOxd9S8qyNl7J8at6GH1SQrDJaYfmK7 fCQkhmJA8xBLdEZLN6kGZ6hPbWHd2Qox8T5T7dMMz6i38xzNTe3uoPpyS4lNklWJ +uq3ERgEHIOsMaaAG/Vqt01pQbkDtmu3H7SNcvb/q1TgDAShlrqvkG9YsUZZs8VO PYQx0T9lHTI8IFKq+IJgRs/NBMhz3UXYnagt5cYb4Vvq2nzdtHua6I6QSydKyPYt ap+t4qdOVwwIVPA08zVKgcFFLLAFgD1u5pyAJ/Qel9ysyNGdWuthxGrw96C4Z4BV 51kiF4CJxyfqAWVVVi1EfcUjT2AwrKJfho+koOVTNi77Vr9F0Z8HWM45oNuKMJYn GAQSswsV5w9Ve41DTWlehEy6fEuGsaSiNrHhJ7kFHjPF1FnlzZNFHpDh9idqXbCj hoJvjU0N8LMJjw== =bNGm -----END PGP SIGNATURE----- --n2wfaq6c23aiuwsc--