Re: git: 2e32d4e41d20 - main - param.h: Bump FreeBSD_Version to 1400058 for devclass newbus changes
Date: Mon, 09 May 2022 16:25:41 UTC
On 5/7/22 2:06 PM, Warner Losh wrote: > On Sat, May 7, 2022, 2:17 PM John Baldwin <jhb@freebsd.org> wrote: > >> On 5/7/22 8:34 AM, Warner Losh wrote: >>> The branch main has been updated by imp: >>> >>> URL: >> https://cgit.FreeBSD.org/src/commit/?id=2e32d4e41d205d6f14834f87306a77ff77b9c0bd >>> >>> commit 2e32d4e41d205d6f14834f87306a77ff77b9c0bd >>> Author: Warner Losh <imp@FreeBSD.org> >>> AuthorDate: 2022-05-07 15:32:47 +0000 >>> Commit: Warner Losh <imp@FreeBSD.org> >>> CommitDate: 2022-05-07 15:32:47 +0000 >>> >>> param.h: Bump FreeBSD_Version to 1400058 for devclass newbus changes >>> >>> jhb changed the newbus ABI and it's affecting some ports. Bump the >>> version to give them something to key off of for the removal of the >>> devclass arg from some macros. In theory the change should have been >>> ABI neutral, but there some build breakage with drm-kmod so better >>> to bump than not. >>> >>> Sponsored by: Netflix >> >> Mmmm, I'm guessing this is from some of the helpers for things like MMC >> and i2c bridges rather than the core macros in sys/bus.h? For the >> regular *DRIVER_MODULE* macros you should still be able to use the devclass >> argument just fine on main still, and I won't remove that until after I >> have MFC'd the API compat shims to 13.x. >> >> Ah, from Cy's followup I'm guessing it isn't actually the macros, but >> the removal of iic_devclass or some such instead (and I haven't planned >> on MFC'ing that), so this bump makes sense for those. >> > > > Should I update the docs then to be more explicit that its these other > devclasses? No, this is probably fine as-is, and probably best to patch any ports to use this version for removing devclass arguments entirely and using the new API. I had planned on bumping when removing the compat shims, but probably should have bumped when the new API was added instead. -- John Baldwin