From nobody Mon May 09 16:25:41 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 6CAE81AC69A0; Mon, 9 May 2022 16:25:43 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4KxmkH2WMyz4ghG; Mon, 9 May 2022 16:25:43 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1652113543; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sQwE4qTU6AAeKDcXPkEB/fqrhbMWlAgeE8K75wbzKxY=; b=ZDuSEy7ijDVsEXUf/TbY2RKz3HumUjdKnSbQ9aJj+NppyFRmHkqJFG/2GLmQPhgC79v1/U G1C2cDEbguBpmt3eB8SvJYH1y2Gn7we/3kW3B7im7VUwWSOK8iA24iy3a149dYnPHVhKk1 6234R3czvU4Q1GadhbWXMNrqyjfgwRkBAtx5cJl0/XJZoACu1QIuHZNb9o4ihSoe7Q4pp7 /tP+PK4u6wmyf7/PKD4DzBAqfUSZj4rwi3yFxN/NDOie7tS1RwcTuKcFe2FHqrASeGI2e1 7RcJWTkwA8N/HvSMjzlS+893bdK9kqSSgLFVEYL8baWItS8bCzeOCJII1+b7Vw== Received: from [10.0.1.4] (ralph.baldwin.cx [66.234.199.215]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id A6990651D; Mon, 9 May 2022 16:25:42 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: <25e65eb5-e2e8-a8ba-b6ae-3740dbb09e54@FreeBSD.org> Date: Mon, 9 May 2022 09:25:41 -0700 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: git: 2e32d4e41d20 - main - param.h: Bump FreeBSD_Version to 1400058 for devclass newbus changes Content-Language: en-US To: Warner Losh Cc: Warner Losh , src-committers , dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org References: <202205071534.247FYcoV087948@gitrepo.freebsd.org> From: John Baldwin In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1652113543; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sQwE4qTU6AAeKDcXPkEB/fqrhbMWlAgeE8K75wbzKxY=; b=Ozpy2g/cjOAHhLtjemLaYUlk5ojKW/RsJNB9dWwRhWN1xALxiBKhWDbxM+3URzcw4HSwGS aL/Kn+PU4rkYrB9xaTEehF9NuP1GXnDKzNiGw+slwS+HD2xluBQCj1bMpBO2Xky9WUt/3n NoKiLRv26HlqlenXcT0N5NuAH2xwboNt7nvPTMjHyaWtjjveo7u3O8/sQoMM2DqOafgSsF rDChiuaTZcb3atsPGQ9/z0KV+Ku3AXpckE7umuq6L4hRVWi4IXhIwiVE25AsNpxp2Put/b oXCmLUUuUouC072A1Q/mLo0Bg5A+JdLz9MFuOk2dYvj3N8aHkXxUVxt90F+OaQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1652113543; a=rsa-sha256; cv=none; b=N7h2iozesybAn7C4+l1H5CTDpBrCmWZw5vTl5zfLRQJ23HVkEYVeUaZz6V+t8bqNXLOaX6 unP82hIwbmjDoKwbazCrhNStyULBRPzezAsjX1irSJ7O0xRhxsUCZJmVJRmwT+MTQMyjUY zVr3WTasiyCMiDiptSLd09XJN/H2cjhNUVhovJbHjXHGY1r8piBflCws/alHaRfn4/JXWI syE2Q6QI0URAvLpQnkdNG18/9K3RMkWPjg1L7FwHmm3zqyRLChlBsWCODjUQfgfBvIyGZO SyCSow+/hE2IsDtxmTKuPoRmOyblXh5VCBbogdMIs3LQ2swsBzOyTn/xDrvsRQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N On 5/7/22 2:06 PM, Warner Losh wrote: > On Sat, May 7, 2022, 2:17 PM John Baldwin wrote: > >> On 5/7/22 8:34 AM, Warner Losh wrote: >>> The branch main has been updated by imp: >>> >>> URL: >> https://cgit.FreeBSD.org/src/commit/?id=2e32d4e41d205d6f14834f87306a77ff77b9c0bd >>> >>> commit 2e32d4e41d205d6f14834f87306a77ff77b9c0bd >>> Author: Warner Losh >>> AuthorDate: 2022-05-07 15:32:47 +0000 >>> Commit: Warner Losh >>> CommitDate: 2022-05-07 15:32:47 +0000 >>> >>> param.h: Bump FreeBSD_Version to 1400058 for devclass newbus changes >>> >>> jhb changed the newbus ABI and it's affecting some ports. Bump the >>> version to give them something to key off of for the removal of the >>> devclass arg from some macros. In theory the change should have been >>> ABI neutral, but there some build breakage with drm-kmod so better >>> to bump than not. >>> >>> Sponsored by: Netflix >> >> Mmmm, I'm guessing this is from some of the helpers for things like MMC >> and i2c bridges rather than the core macros in sys/bus.h? For the >> regular *DRIVER_MODULE* macros you should still be able to use the devclass >> argument just fine on main still, and I won't remove that until after I >> have MFC'd the API compat shims to 13.x. >> >> Ah, from Cy's followup I'm guessing it isn't actually the macros, but >> the removal of iic_devclass or some such instead (and I haven't planned >> on MFC'ing that), so this bump makes sense for those. >> > > > Should I update the docs then to be more explicit that its these other > devclasses? No, this is probably fine as-is, and probably best to patch any ports to use this version for removing devclass arguments entirely and using the new API. I had planned on bumping when removing the compat shims, but probably should have bumped when the new API was added instead. -- John Baldwin