Re: git: 1f7746d81f53 - main - bsdinstall: stop messing with file descriptors

From: Emmanuel Vadot <manu_at_bidouilliste.com>
Date: Tue, 03 May 2022 14:07:40 UTC
On Tue, 3 May 2022 14:06:32 GMT
Emmanuel Vadot <manu@FreeBSD.org> wrote:

> The branch main has been updated by manu:
> 
> URL: https://cgit.FreeBSD.org/src/commit/?id=1f7746d81f53447ac15cc99395bb714d4dd0a4da
> 
> commit 1f7746d81f53447ac15cc99395bb714d4dd0a4da
> Author:     Corvin Köhne <CorvinK@beckhoff.com>
> AuthorDate: 2022-05-03 14:00:09 +0000
> Commit:     Emmanuel Vadot <manu@FreeBSD.org>
> CommitDate: 2022-05-03 14:02:27 +0000
> 
>     bsdinstall: stop messing with file descriptors
>     
>     Throughout the bsdinstall script fd 3 is used by f_dprintf (set through
>     $TERMINAL_STDOUT_PASSTHRU). By closing file descriptor 3 here, the
>     final f_dprintf "Installation Completed ... does not work anymore.
>     
>     By putting the code into a subshell, file descriptors can be edited
>     without interference with the calling script.
>     
>     Reviewed by:            emaste
>     Differential Revision:  https://reviews.freebsd.org/D35113
>     Sponsored by:           Beckhoff Automation GmbH & Co. KG
>     MFC after:              3 days


Fixes 40923b0c81 "Fix scripted installation from media without local
distfiles."

-- 
Emmanuel Vadot <manu@bidouilliste.com> <manu@freebsd.org>