From nobody Tue May 03 14:07:40 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 32D151ABC80F; Tue, 3 May 2022 14:07:44 +0000 (UTC) (envelope-from manu@bidouilliste.com) Received: from mx.blih.net (mx.blih.net [212.83.155.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mx.blih.net", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Kt1xq1PCzz3k9w; Tue, 3 May 2022 14:07:42 +0000 (UTC) (envelope-from manu@bidouilliste.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bidouilliste.com; s=mx; t=1651586861; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=n5wmb2T51PNMTYNGYfXGT1CJkbC9Zn+pCbbYE2gSTRM=; b=CEqdmaNCq5a2YdfzPnK2MdQeoE963qlgek3jifNTKD1f0a54MvCjWCGX8XLrXbv6PMHJXl uEfCJKJeWPhpYuD1VLyBa81W+w3cuOk1v+6K3+V6Gi2LkpsU8+feLJtG3UwXDt5foLbWvB pTxC6cH2lr8j9JtiZHkeihYbJrPDERo= Received: from skull.home.blih.net (lfbn-idf2-1-1209-45.w90-92.abo.wanadoo.fr [90.92.34.45]) by mx.blih.net (OpenSMTPD) with ESMTPSA id 4f3f1234 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Tue, 3 May 2022 14:07:41 +0000 (UTC) Date: Tue, 3 May 2022 16:07:40 +0200 From: Emmanuel Vadot To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 1f7746d81f53 - main - bsdinstall: stop messing with file descriptors Message-Id: <20220503160740.3cae79b06ee16317a4368500@bidouilliste.com> In-Reply-To: <202205031406.243E6WIb078279@gitrepo.freebsd.org> References: <202205031406.243E6WIb078279@gitrepo.freebsd.org> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; amd64-portbld-freebsd14.0) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 4Kt1xq1PCzz3k9w X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bidouilliste.com header.s=mx header.b=CEqdmaNC; dmarc=pass (policy=none) header.from=bidouilliste.com; spf=pass (mx1.freebsd.org: domain of manu@bidouilliste.com designates 212.83.155.74 as permitted sender) smtp.mailfrom=manu@bidouilliste.com X-Spamd-Result: default: False [-3.50 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[bidouilliste.com:s=mx]; FREEFALL_USER(0.00)[manu]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; R_SPF_ALLOW(-0.20)[+ip4:212.83.155.74/32:c]; MV_CASE(0.50)[]; MIME_GOOD(-0.10)[text/plain]; TO_DN_NONE(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; DKIM_TRACE(0.00)[bidouilliste.com:+]; MID_RHS_MATCH_FROM(0.00)[]; DMARC_POLICY_ALLOW(-0.50)[bidouilliste.com,none]; NEURAL_HAM_SHORT(-1.00)[-1.000]; MLMMJ_DEST(0.00)[dev-commits-src-all,dev-commits-src-main]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:12876, ipnet:212.83.128.0/19, country:FR]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[] X-ThisMailContainsUnwantedMimeParts: N On Tue, 3 May 2022 14:06:32 GMT Emmanuel Vadot wrote: > The branch main has been updated by manu: >=20 > URL: https://cgit.FreeBSD.org/src/commit/?id=3D1f7746d81f53447ac15cc99395= bb714d4dd0a4da >=20 > commit 1f7746d81f53447ac15cc99395bb714d4dd0a4da > Author: Corvin K=F6hne > AuthorDate: 2022-05-03 14:00:09 +0000 > Commit: Emmanuel Vadot > CommitDate: 2022-05-03 14:02:27 +0000 >=20 > bsdinstall: stop messing with file descriptors > =20 > Throughout the bsdinstall script fd 3 is used by f_dprintf (set throu= gh > $TERMINAL_STDOUT_PASSTHRU). By closing file descriptor 3 here, the > final f_dprintf "Installation Completed ... does not work anymore. > =20 > By putting the code into a subshell, file descriptors can be edited > without interference with the calling script. > =20 > Reviewed by: emaste > Differential Revision: https://reviews.freebsd.org/D35113 > Sponsored by: Beckhoff Automation GmbH & Co. KG > MFC after: 3 days Fixes 40923b0c81 "Fix scripted installation from media without local distfiles." --=20 Emmanuel Vadot