Re: git: cdcd52d41e24 - main - irdma: Add RDMA driver for Intel(R) Ethernet Controller E810

From: John Baldwin <jhb_at_FreeBSD.org>
Date: Fri, 10 Jun 2022 22:29:12 UTC 
On 5/23/22 4:54 PM, Eric Joyner wrote:
> The branch main has been updated by erj:
> 
> URL: https://cgit.FreeBSD.org/src/commit/?id=cdcd52d41e246ba1c0fcfad0769bd691487355ef
> 
> commit cdcd52d41e246ba1c0fcfad0769bd691487355ef
> Author:     Bartosz Sobczak <bartosz.sobczak@intel.com>
> AuthorDate: 2022-05-23 23:39:27 +0000
> Commit:     Eric Joyner <erj@FreeBSD.org>
> CommitDate: 2022-05-23 23:52:49 +0000
> 
>      irdma: Add RDMA driver for Intel(R) Ethernet Controller E810
>      
>      This is an initial commit for RDMA FreeBSD driver for Intel(R) Ethernet
>      Controller E810, called irdma.  Supporting both RoCEv2 and iWARP
>      protocols in per-PF manner, RoCEv2 being the default.
>      
>      Testing has been done using krping tool, perftest, ucmatose, rping,
>      ud_pingpong, rc_pingpong and others.
>      
>      Signed-off-by: Eric Joyner <erj@FreeBSD.org>
>      
>      Reviewed by:    #manpages (pauamma_gundo.com) [documentation]
>      MFC after:      1 week
>      Relnotes:       yes
>      Sponsored by:   Intel Corporation
>      Differential Revision:  https://reviews.freebsd.org/D34690

I'm trying to get the tree building again with GCC and ld.bfd does not like
libirdma.map at all complaining with an error:

duplicate expression '*' in version information

I looked at the version map, and it seems rather bogus to me and not like
version maps used anywhere else.  It seems to be exporting all symbols in
two different versions?  That would seem to defeat the point of having
symbol versions?

/* Export symbols should be added below according to
    Documentation/versioning.md document. */
IRDMA_1.0 {
	global: *;
	local: *;
};

IRDMA_1.1 {
	global: *;
} IRDMA_1.0;

(I'm also not sure why lld accepts such a version map.)

-- 
John Baldwin